Skip to content

Refactor Cleanup #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimitribouniol merged 1 commit into from
Aug 5, 2026
Merged

Refactor Cleanup #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Sources/CodableDatastore/Persistence/Disk Persistence/Transaction/Transaction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,13 +340,6 @@ extension DiskPersistence {
) -> Self? {
TransactionTaskLocals.transaction(for: persistence).map({ $0 as! Self })
}

/// Check to see if we are in a transaction that pertains to a different persistence than the one provided.
///
/// This is determined by checking if the only transactions present belong to other persistences. If there are no other transactions, or a transaction for the persistence is already registered, it has already been vetted and is no longer considered external.
nonisolated static func isTransactingExternally(to persistence: DiskPersistence<AccessMode>) -> Bool {
!TransactionTaskLocals.transactionStorage.isEmpty && TransactionTaskLocals.transactionStorage[ObjectIdentifier(persistence)] == nil
}
}
}

Expand Down