Conversation
Recognize Winsock WSAECONNRESET errors when classifying transient network failures, while retaining ECONNRESET on other platforms. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Retry transient token request failures in both the client auth provider and daemon authorizer. Reuse the existing retry policy, leave retry ownership with an enclosing handler, and interrupt backoff when the context is canceled. Preserve the existing GET and POST fallback behavior. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry transient registry token failures in both the client auth provider and daemon authorizer, allowing builds to recover from connection resets and temporary server errors. Token requests reuse the existing retry policy, while requests already covered by an image handler leave retry ownership with that handler to avoid multiplying attempts and backoff. Cancellation interrupts backoff, existing GET/POST fallback behavior is preserved, and Windows connection resets are correctly recognized as
WSAECONNRESET.