Skip to content

source/http: report errors before checksum mismatch #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Karthik-Chowdary wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −0
Open

source/http: report errors before checksum mismatch #7113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/http/source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,9 @@ func (hs *httpSourceHandler) Snapshot(ctx context.Context, jobCtx solver.JobCont
defer func() {
_ = resp.Body.Close()
}()
if resp.StatusCode < 200 || resp.StatusCode >= 400 {
return nil, errors.Errorf("invalid response status %d", resp.StatusCode)
}

ref, dgst, err := hs.save(ctx, resp, g)
if err != nil {
Expand Down
27 changes: 27 additions & 0 deletions source/http/source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package http

import (
"context"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"testing"
Expand Down Expand Up @@ -315,6 +317,31 @@ func TestHTTPChecksum(t *testing.T) {
ref = nil
}

func TestHTTPChecksumReturnsResponseStatus(t *testing.T) {
t.Parallel()
ctx := t.Context()

server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusForbidden)
_, _ = w.Write([]byte("forbidden response body"))
}))
defer server.Close()

hs, err := newHTTPSource(t)
require.NoError(t, err)
id := &HTTPIdentifier{
URL: server.URL + "/artifact",
Checksum: digest.FromString("expected"),
}
h, err := hs.Resolve(ctx, id, nil, nil)
require.NoError(t, err)
_, _, _, _, err = h.CacheKey(ctx, nil, 0)
require.NoError(t, err)

_, err = h.Snapshot(ctx, nil)
require.ErrorContains(t, err, "invalid response status 403")
}

func TestHTTPSignatureVerification(t *testing.T) {
t.Parallel()
ctx := t.Context()
Expand Down