feat: surface enabled, selected and focused attributes from ios ui dump - #369
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe source-tree element model now captures optional enabled, selected, and focus states. The filtering path transfers these values to generated ChangesSource element state propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adds optional iOS state attributes while preserving behavior when attributes are absent; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Summary
enabled,selectedandhasFocusattributes emitted by devicekit-ios and map them ontoScreenElement(hasFocus→focused), matching the fields already populated on AndroidTest plan
TestFilterSourceElementsPreservesStateAttributescovers the mappingRequires devicekit-ios release with mobile-next/devicekit-ios#69 (agent version bump will follow separately).
Summary by CodeRabbit
New Features
Documentation
Tests