Skip to content

refactor: simplify logs - #70

Merged
gmegidish merged 1 commit into
mainfrom
refactor/remove-fblogger
Aug 31, 2026
Merged

refactor: simplify logs#70
gmegidish merged 1 commit into
mainfrom
refactor/remove-fblogger

Conversation

@gmegidish

@gmegidish gmegidish commented Aug 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 690a8be5-79b4-41db-a1ca-975d55d66ee8

📥 Commits

Reviewing files that changed from the base of the PR and between c112eb8 and 11f3665.

📒 Files selected for processing (7)
  • DeviceKitTests/Categories/XCUIApplication+Helper.m
  • DeviceKitTests/Categories/XCUIApplicationProcess+FBQuiescence.m
  • DeviceKitTests/Utilities/FBLogger.h
  • DeviceKitTests/Utilities/FBLogger.m
  • DeviceKitTests/Utilities/FBScreenshot.m
  • DeviceKitTests/Utilities/XCTestDaemonsProxy.m
  • devicekit-ios.xcodeproj/project.pbxproj
💤 Files with no reviewable changes (3)
  • DeviceKitTests/Utilities/FBLogger.m
  • devicekit-ios.xcodeproj/project.pbxproj
  • DeviceKitTests/Utilities/FBLogger.h

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


Walkthrough

The change removes the unused FBLogger implementation and its Xcode project entries. Test helpers and utilities replace FBLogger calls with NSLog. Quiescence behavior, screenshot error handling, timeout control flow, and proxy initialization behavior remain unchanged.

Merge Risk: ⚪ Minimal · up to 11f36

This localized logging refactor has no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so its relevance to the changeset cannot be assessed. Add a brief description that explains the removal of FBLogger and its replacement with direct NSLog calls.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the logging simplification in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-fblogger

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit 947489a into main Aug 31, 2026
4 checks passed
@gmegidish
gmegidish deleted the refactor/remove-fblogger branch August 31, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant