fix: scope sync PR to models and generated packages - #323
Merged
Conversation
The sync workflow's npm ci step removes the repo's committed node_modules symlink, and create-pull-request staged that deletion. Restrict the PR to models/** and packages/** so a sync can never touch anything else.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
models/**andpackages/**viaadd-paths.Why
The previous auto-sync (#322) accidentally deleted the repo's committed
node_modulessymlink —npm ciremoves it andcreate-pull-requeststaged that deletion. Restricting the paths means a sync can only ever touch model YAMLs and the regenerated packages.Notes
node_modulessymlink (a broken local-path artifact from feat: bedrock provider — 56 models, region-portable ids #307) is already gone frommainas a side effect; this prevents any future recurrence.