refactor: collapse lumilake plugins into lumid_lumilake_plugin#6
Open
timzsu wants to merge 4 commits into
Open
refactor: collapse lumilake plugins into lumid_lumilake_plugin#6timzsu wants to merge 4 commits into
timzsu wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two new optional surfaces to
lumid_lumilake_plugin— jobs auth and remote optimizer — alongside the existing identity provider. All three share oneinstall()and oneLUMILAKE_PLUGINS=lumid_lumilake_pluginentry; each new surface activates by env var:PermissionChecker+ResourceRegistrar) — kind-agnostic SQLite ACL store; grants persist across restarts via reconcile. Activates whenLUMID_LUMILAKE_ACL_DB_PATHis set.OptimizerProvider) — proxies schedule requests to a trusted upstream URL. Install-time catalog probe uses Lumilake's existingLUMILAKE_RUNTIME_TOKEN; per-job schedule calls forward the submitter's own lum.id bearer via upstreamruntime_token_var, so every schedule is attributed to the real caller (no static service-account token on the user path). Activates whenLUMILAKE_REMOTE_OPTIMIZER_URLis set.Why
Lumilake needs grant-scoped permission checks for jobs/traces/artifacts and a way to delegate optimizer scheduling to a remote. Keeping both in the same plugin lets the lum.id identity core stay in one place — the same
LumidIdentityProviderpowers all three surfaces.Test Plan
End-to-end against a kv.run-deployed Lumilake with a remote optimizer.