Skip to content

[Fix] Fix tests for current helm chart otel configuration#300

Open
royischoss wants to merge 1 commit into
mlrun:developmentfrom
royischoss:fix-otel-tests
Open

[Fix] Fix tests for current helm chart otel configuration#300
royischoss wants to merge 1 commit into
mlrun:developmentfrom
royischoss:fix-otel-tests

Conversation

@royischoss

@royischoss royischoss commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

📝 Description

Fixed 13 failing tests in tests/helm-template-test.sh that were stale relative to recent OTel changes:


🛠️ Changes Made

  • Collector test: updated expected upgradeStrategy from automatic to none (the new default in values.yaml).
  • Instrumentation tests (Python + Java): added the missing --set opentelemetry.collector.enabled=true flag — the installer template needs the collector enabled to render.
  • Jupyter test: flipped the assertion to confirm Jupyter does not get the mlrun.io/otel label, matching the intentional design (Jupyter is not auto-instrumented).
  • Namespace-label test: removed the obsolete kubectl annotate assertion — instrumentation is now opt-in per pod, not namespace-wide.

Result: 67 passed, 0 failed (was 56/13). helm lint clean.


✅ Checklist

  • I have tested the changes in this PR
  • I confirmed whether my changes require a change in documentation and if so, I created another PR in MLRun for the relevant documentation.
  • I confirmed whether my changes require a changes in QA tests, for example: credentials changes, resources naming change and if so, I updated the relevant Jira ticket for QA.
  • I increased the Chart version in charts/mlrun-ce/Chart.yaml.
  • I confirmed that the installation works both on a local Docker Desktop environment and on a real cluster when using the required prerequisites.
    • If installation issues were found, I updated the relevant Jira ticket with the issue and steps to reproduce, or updated the prerequisites documentation if the issue is related to missing or outdated prerequisites.
  • If needed, update https://github.com/mlrun/ce/blob/development/charts/mlrun-ce/README.md with the relevant installation instructions and version Matrix.
  • If needed, update the following values files for multi namespace support:

🧪 Testing

Ran test manually


🔗 References

  • Ticket link:
  • External links:
  • Design docs links (Optional):

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@royischoss royischoss changed the title [OTEL] Fix tests for current helm chart otel configuration [Fix] Fix tests for current helm chart otel configuration Jun 9, 2026
@github-actions github-actions Bot added the bug Something isn't working label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant