refactor: give each shape its own parameter type - #100
Merged
Conversation
The `Parameter` union listed the parameters of every shape in one place, away from the shapes themselves, and `ParameterTuple` existed only to constrain a shape's tuple against that list. Each shape now declares its own `<Shape>Parameter` union next to its class and `Shape1DParameter` combines them, so a shape's parameters are declared where the shape is. Assisted-By: Claude Opus 5
A symlink named `node_modules` was committed by mistake. `.gitignore` listed `node_modules/` with a trailing slash, which matches a directory only, so a symlink of that name was never ignored. Checking the repository out replaces an installed `node_modules` directory with that dangling symlink, after which no tool resolves and `npm ci` fails. Dropping the trailing slash ignores the path whatever its type. Assisted-By: Claude Opus 5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 24 24
Lines 1088 1088
Branches 242 242
=======================================
Hits 1046 1046
Misses 41 41
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Parameterunion listed the parameters of every shape in one place, away from the shapes themselves, andParameterTupleexisted only to constrain a shape's tuple against that list. Each shape now declares its own<Shape>Parameterunion next to its class andShape1DParametercombines them.