🔒 Fix Command/Argument Injection Vulnerability in SafeProcess.LaunchApp#20
🔒 Fix Command/Argument Injection Vulnerability in SafeProcess.LaunchApp#20mleem97 wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
A potential Command/Argument Injection vulnerability existed in
SafeProcess.LaunchAppdue to passing user-provided strings directly as concatenated command-lineArguments.If an attacker controls the
argumentsstring, they could inject arbitrary arguments, potentially leading to arbitrary code execution or unintended app behaviors. Also,exePathwasn't validated, meaning executables relative toPATHcould be hijacked.🛡️ Solution:
Refactored
LaunchAppto take anIEnumerable<string>instead of a rawstringfor arguments, and mapped them toProcessStartInfo.ArgumentList. This delegates the escaping to .NET/the OS. Also added validations viaPath.IsPathRootedandFile.ExistsforexePath. UpdatedOpenFolderandOpenExplorerAndSelectin the same class to also useArgumentList. Updated the only callsite inSettingsPage.axaml.cs.PR created automatically by Jules for task 5942240774046774104 started by @mleem97