Skip to content

🔒 Fix Command/Argument Injection Vulnerability in SafeProcess.LaunchApp#20

Open
mleem97 wants to merge 2 commits into
mainfrom
jules-5942240774046774104-0a425d99
Open

🔒 Fix Command/Argument Injection Vulnerability in SafeProcess.LaunchApp#20
mleem97 wants to merge 2 commits into
mainfrom
jules-5942240774046774104-0a425d99

Conversation

@mleem97
Copy link
Copy Markdown
Owner

@mleem97 mleem97 commented May 21, 2026

🎯 What:
A potential Command/Argument Injection vulnerability existed in SafeProcess.LaunchApp due to passing user-provided strings directly as concatenated command-line Arguments.

⚠️ Risk:
If an attacker controls the arguments string, they could inject arbitrary arguments, potentially leading to arbitrary code execution or unintended app behaviors. Also, exePath wasn't validated, meaning executables relative to PATH could be hijacked.

🛡️ Solution:
Refactored LaunchApp to take an IEnumerable<string> instead of a raw string for arguments, and mapped them to ProcessStartInfo.ArgumentList. This delegates the escaping to .NET/the OS. Also added validations via Path.IsPathRooted and File.Exists for exePath. Updated OpenFolder and OpenExplorerAndSelect in the same class to also use ArgumentList. Updated the only callsite in SettingsPage.axaml.cs.


PR created automatically by Jules for task 5942240774046774104 started by @mleem97

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant