Land the unit-label removal and the Drive fallback on main - #5
Merged
Conversation
A unit number belongs to one course's outline, and this package serves more than one course. A Research to Production student is handed all twenty components, never sat the Foundations unit that writes the baseline, and would have read "unit 2.5" in their own submission report, in `describe()`, and in `status()`. It also drifted, in three directions at once. Foundations' components.md had thirteen hand-corrected rows while `Contract.units` kept the old numbers, and eleven module docstrings here kept a third set - allocator's said 8.1 and 8.2 where the registry said 7.1 and 7.2, and nothing could have caught it, because a docstring is not read by anything. So `Contract.units` goes, with `Conformance.unit`, the report's per-component `unit` key, the `status()` column, the stamp's `unit` field, and every unit number in a docstring or a message - replaced by the thing it referred to, which is what the reader needed anyway. foundations-dev@c2d40ec picks the mapping up next to the units it describes, where a renumbering that moves a folder fails its build. Its components.md regenerates byte for byte identical, which is the evidence nothing was lost. 118 passed, 1 skipped.
google.colab being importable is not evidence a Drive can be mounted. The published Colab runtime image ships the package with no backend behind it, so drive.mount raises NotImplementedError and setup() dies before home() ever consults the ML4T_FOUNDATIONS_HOME override that exists for this case. Every Foundations notebook that calls setup() therefore fails the repo's own Colab image check. mount_drive now reports whether MyDrive is actually there, so a mount that raises and a mount that returns without producing the folder both send home() to its fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3 was based on
feat/long-panelrather thanmain, so merging it landed its commits on that branch instead. This carries them the rest of the way.a79a38acontracts no longer name a Foundations unit045c057setup()falls back instead of raising when Drive cannot be mounted