Lint fixes#2663
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Small "lint fixes" PR that removes an extraneous blank line in the leaderboard module and drops an unused config import from the leaderboard slash command file. To make the import unused, the admin authorization check in handleRun was simplified to no longer accept config.AdminUserID as a permitted caller.
Changes:
- Remove a stray blank line after
GetGuildLBConfigsinleaderboard.go. - Drop the
configpackage import fromleaderboard_slashcmd.go. - Tighten the
handleRunpermission check to require Discord Administrator only, removing theconfig.AdminUserIDbypass.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/leaderboard/leaderboard.go | Cosmetic: removed an extra blank line. |
| src/leaderboard/leaderboard_slashcmd.go | Removed config import and the config.AdminUserID bypass in the admin check for handleRun. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| perms, err := s.UserChannelPermissions(userID, i.ChannelID) | ||
| if err != nil || (perms&discordgo.PermissionAdministrator == 0 && userID != config.AdminUserID) { | ||
| if err != nil || (perms&discordgo.PermissionAdministrator == 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.