Changed order of display items#2661
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reorders leaderboard display items in the Core and Miscellaneous stat groups and removes a redundant backup != nil check that's already guaranteed by an outer guard.
Changes:
- Reordered
group_coremembers so TE Total sits next to Soul/Prophecy Eggs and Contract Exp moves later. - Reordered
group_miscmembers to put Prestiges first. - Dropped redundant
backup != nilcheck inside an alreadybackup != nil-guarded block.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/leaderboard/leaderboard.go | Reorders members in group_core and group_misc LB display groups. |
| src/leaderboard/leaderboard_calculators.go | Removes redundant nil check (block already inside if backup != nil). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.