fix: grammar & spelling mistakes - #111
Open
BobbedBob wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines user-facing copy and test assertions across MFA templates to correct spelling/grammar and improve phrasing consistency in authentication and device-trust flows.
Changes:
- Corrected “confirm you identity” → “confirm your identity” in both template copy and its corresponding test assertion.
- Improved wording in Trusted Device and TOTP setup instructions for clearer user guidance.
- Normalized several headings by removing unintended leading whitespace in
<strong>text.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mfa/tests/test_fido2.py | Updates asserted template text to match corrected user-facing copy. |
| mfa/templates/TrustedDevices/start.html | Adjusts trusted-device start-page messaging and step instructions. |
| mfa/templates/TrustedDevices/Add.html | Improves wording for the trusted-device add flow and confirmations. |
| mfa/templates/TOTP/recheck.html | Removes unintended leading whitespace in the OTP heading. |
| mfa/templates/TOTP/Add.html | Clarifies the device/app wording used for scanning the TOTP QR code. |
| mfa/templates/RECOVERY/recheck.html | Removes unintended leading whitespace in the recovery heading. |
| mfa/templates/FIDO2/Add.html | Fixes identity confirmation text shown during FIDO2 registration. |
| mfa/templates/Email/recheck.html | Removes unintended leading whitespace in the email OTP heading. |
| mfa/templates/Email/Add.html | Removes unintended leading whitespace in the email token activation heading. |
Suppressed comments (1)
mfa/templates/TrustedDevices/start.html:31
- "tables" looks like a typo here (this view is about mobile/tablet device approval). This reads oddly to users.
<div class="alert alert-danger">You can't add any more devices at the moment, you need to remove previously
trusted devices first.
</div>
{% else %}
<p class="success-message">Allow access from mobile phone and tables.</p><br/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
10
to
12
| <div class="panel-heading card-header"> | ||
| <strong> Email One Time Password </strong> | ||
| <strong>Email One Time Password </strong> | ||
| </div> |
mkalioby
approved these changes
Aug 4, 2026
mkalioby
left a comment
Owner
There was a problem hiding this comment.
Thanks and welcome to the contributors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few grammar & spelling mistakes (e.g. ... to confirm you identity... into ... to confirm your identity), and some wording has been corrected into a more natural way to express the same thing.