Skip to content

Add light box gallery#2444

Open
Lisa18289 wants to merge 19 commits into
mainfrom
add-light-box-gallery
Open

Add light box gallery#2444
Lisa18289 wants to merge 19 commits into
mainfrom
add-light-box-gallery

Conversation

@Lisa18289
Copy link
Copy Markdown
Member

@Lisa18289 Lisa18289 commented Apr 10, 2026

No description provided.

@Lisa18289 Lisa18289 self-assigned this Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 81.65% 276 / 338
🔵 Statements 81.97% 282 / 344
🔵 Functions 87.67% 64 / 73
🔵 Branches 70.87% 129 / 182
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
Generated in workflow #5250 for commit 0c25f1b by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label Apr 10, 2026
@github-actions github-actions Bot removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

@Lisa18289
Merge remote-tracking branch 'origin/main' into add-light-box-gallery
6f8415d
@Lisa18289
update gallery
9c0526e
@Lisa18289
Merge remote-tracking branch 'origin/main' into add-light-box-gallery
4396540 
# Conflicts:
#	packages/components/src/components/LightBox/LightBox.tsx
#	packages/components/src/components/propTypes/index.ts
@Lisa18289
update gallery
1110c21
@Lisa18289 Lisa18289 added update-screenshots Label a PR to update the screenshots used for visual regression testing labels Apr 24, 2026
@github-actions github-actions Bot removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

github-actions Bot and others added 2 commits April 24, 2026 05:35
@github-actions @Lisa18289
test: update visual regression screenshots
ebbb9b6 
Co-authored-by: Lisa18289 <84317589+Lisa18289@users.noreply.github.com>
@Lisa18289
Merge branch 'main' into add-light-box-gallery
e87cb21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

Jan-Eimertenbrink
Jan-Eimertenbrink requested changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Jan-Eimertenbrink Jan-Eimertenbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already feeling really good and close to what I had in mind. I have a few suggestions that could improve the experience further:

  1. Keyboard navigation in the gallery
    Once inside the gallery, I would expect to be able to navigate between images using the arrow keys. That would make keyboard interaction much smoother and aligns with common patterns, for example in the Google Play Store.

  2. Spacing from the screen edges
    I think the Buttons could have a bit more space from the border, especially on larger screens where they currently feel slightly too close to the borders. Maybe something around 32px could work, but we can review that together. I’d still keep them visually anchored toward the edges, similar to how it’s handled in the Google Play Store.

  3. Gallery looping behavior (open for discussion)
    I’m a bit undecided here and would love your thoughts. Should the gallery loop from the last image back to the first?

There are pros and cons:

  • Looping makes it easy to continuously browse in one direction and quickly jump from the first to the last image.
  • On the other hand, having a clear start and end (no looping) gives users a stronger sense of completion when they reach the last image.

I can see good arguments for both approaches, so I’d be interested in your perspective.

@Jan-Eimertenbrink Jan-Eimertenbrink linked an issue Apr 28, 2026 that may be closed by this pull request
Improve LightBox Component #1836
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

@Lisa18289 Lisa18289 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label May 4, 2026
@github-actions github-actions Bot removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label May 4, 2026
github-actions Bot and others added 2 commits May 4, 2026 09:09
@github-actions @Lisa18289
test: update visual regression screenshots
62cc0f1 
Co-authored-by: Lisa18289 <84317589+Lisa18289@users.noreply.github.com>
@Lisa18289
Merge branch 'main' into add-light-box-gallery
3247362
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

@Lisa18289 Lisa18289 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label May 4, 2026
@github-actions github-actions Bot removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label May 4, 2026
@github-actions @Lisa18289
test: update visual regression screenshots
cd1866b 
Co-authored-by: Lisa18289 <84317589+Lisa18289@users.noreply.github.com>
@Lisa18289 Lisa18289 marked this pull request as ready for review May 6, 2026 04:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-2444.docs.review.flow-components.de
storybook pr-2444.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-2444
  • storybook: ghcr.io/mittwald/flow/storybook:pr-2444

@Lisa18289 Lisa18289 enabled auto-merge (squash) May 6, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jan-Eimertenbrink Jan-Eimertenbrink Jan-Eimertenbrink requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Lisa18289 Lisa18289

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve LightBox Component

2 participants

@Lisa18289 @Jan-Eimertenbrink