Skip to content

TASK TOOLPIN-E-4021 — Pin the Rust toolchain to 1.97.0 - #54

Merged
olympum merged 1 commit into
mainfrom
task/4021-pin-rust-1970
Aug 14, 2026
Merged

TASK TOOLPIN-E-4021 — Pin the Rust toolchain to 1.97.0#54
olympum merged 1 commit into
mainfrom
task/4021-pin-rust-1970

Conversation

@olympum

@olympum olympum commented Aug 14, 2026

Copy link
Copy Markdown
Member

build: pin the Rust toolchain to 1.97.0

This repository was invisible to the TOOLPIN plan, which enumerated nine Rust
repositories from a hand-derived list. scripts/ci/rust_pin_audit.py derives them
from their trees instead, and found this one on its first live run.

1.97.0 is the ratified estate version (D207).

One target, measured rather than guessed:

aarch64-apple-darwin    .github/workflows/component-artifacts.yml

Verified under the pinned compiler:

rustc in-tree   rustc 1.97.0 (2d8144b78 2026-07-07)
gate            cargo clippy --workspace --all-targets -- -D warnings exit 0; cargo test --workspace exit 0, 100 + 4 tests

src/main.rs carries three clippy-1.97 changes, and they are not all the same kind.

Two are fixes. clippy::ptr_arg fires on the unmodified source under 1.97.0, so
Option<&PathBuf> becomes Option<&Path> and as_ref() becomes as_deref().

One is a SUPPRESSION, stated as such: #[allow(clippy::too_many_arguments)] on
onboard_output. The function took eight arguments before this change and takes
eight after, so its arity did not move -- 1.97.0 tightened the default. The
suppression is defensible for a print helper whose arguments are all distinct
values, but it is a silenced lint rather than a fixed one, and it should not be
absorbed into 'pinned the toolchain'.

Both lints were confirmed to fire by reverting the source, keeping the pin, and
running the repository's own clippy invocation:

clippy::ptr_arg
clippy::too_many_arguments

Fixes #4021

This repository was invisible to the TOOLPIN plan, which enumerated nine Rust
repositories from a hand-derived list. scripts/ci/rust_pin_audit.py derives them
from their trees instead, and found this one on its first live run.

1.97.0 is the ratified estate version (D207).

One target, measured rather than guessed:

    aarch64-apple-darwin    .github/workflows/component-artifacts.yml

Verified under the pinned compiler:

    rustc in-tree   rustc 1.97.0 (2d8144b78 2026-07-07)
    gate            cargo clippy --workspace --all-targets -- -D warnings exit 0; cargo test --workspace exit 0, 100 + 4 tests

src/main.rs carries three clippy-1.97 changes, and they are not all the same kind.

Two are fixes. `clippy::ptr_arg` fires on the unmodified source under 1.97.0, so
`Option<&PathBuf>` becomes `Option<&Path>` and `as_ref()` becomes `as_deref()`.

One is a SUPPRESSION, stated as such: `#[allow(clippy::too_many_arguments)]` on
`onboard_output`. The function took eight arguments before this change and takes
eight after, so its arity did not move -- 1.97.0 tightened the default. The
suppression is defensible for a print helper whose arguments are all distinct
values, but it is a silenced lint rather than a fixed one, and it should not be
absorbed into 'pinned the toolchain'.

Both lints were confirmed to fire by reverting the source, keeping the pin, and
running the repository's own clippy invocation:

    clippy::ptr_arg
    clippy::too_many_arguments

Fixes #4021
@olympum
olympum merged commit 144db33 into main Aug 14, 2026
1 check passed
@olympum
olympum deleted the task/4021-pin-rust-1970 branch August 14, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant