Skip to content

Allow native player discovery in diagnostic checks - #15

Merged
mitchtech merged 1 commit into
mainfrom
mm/reliable-diagnostic-checks
Nov 8, 2026
Merged

mitchtech merged 1 commit into
mainfrom
mm/reliable-diagnostic-checks

Conversation

@mitchtech

Copy link
Copy Markdown
Owner

The diagnostic test could kill doctor after three seconds on a loaded Windows runner and then assert against partial output. Allow fifteen seconds, assert subprocess errors and signals explicitly, and check output and exit status from the same invocation. All contributor checks pass locally; the PR runs the six operating system and Node combinations.

@mitchtech
mitchtech merged commit 0eafd12 into main Nov 8, 2026
12 checks passed
@mitchtech
mitchtech deleted the mm/reliable-diagnostic-checks branch November 9, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant