Skip to content

kqueue: register mach-port wakeups on every Darwin target (iOS never woke) #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adriangalilea wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kqueue: register mach-port wakeups on every Darwin target (iOS never woke) #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/backend/kqueue.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ pub const Loop = struct {
// Add to our completion queue
c.task_loop.thread_pool_completions.push(c);

if (comptime builtin.target.os.tag == .macos) {
if (comptime builtin.target.os.tag.isDarwin()) {
// Wake up our main loop
c.task_loop.wakeup() catch {};
}
Expand Down Expand Up @@ -1070,7 +1070,10 @@ pub const Completion = struct {
.udata = @intFromPtr(self),
}),

.machport => if (comptime builtin.os.tag != .macos) return null else kevent: {
// Every Darwin target, not just macOS: Async is a mach port on
// all of them (watcher/async.zig picks by isDarwin), and iOS
// silently never registered its wakeups here.
.machport => if (comptime !builtin.os.tag.isDarwin()) return null else kevent: {
// We can't use |*v| above because it crahses the Zig
// compiler (as of 0.11.0-dev.1413). We can retry another time.
const v = &self.op.machport;
Expand Down