document silent disconnect handling#111
Open
eponymz wants to merge 6 commits into
Open
Conversation
This adds the event sent by slack when the server is going to disconnect the websocket. Add ability to handle the event.
Stuck in ES6 mind-set.. oops
(using github UI editor)
figured a workaround that would require minimal change to the repo and has gone through rigorous PR review by my company. (confirmation that it works happened today) logs dont lie
this will assist *many* people dealing with the frustration of silent disconnects. Server will still run but the bot will show as offline.
realized the code styling and event handling for my code was less generic (not everyone has one handle function for message event). removed and noted that any bot event handler should be in the startBot() function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds my sample code for handling the silent disconnects into the readme.