Skip to content

support windows #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicerloop wants to merge 8 commits into from
Closed

support windows #4

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
87b537a
support windows
nicerloop Dec 23, 2025
f5a0d60
fix: use correct path variable in post_install
nicerloop Apr 15, 2026
0092477
OS detection based on RUNTIME.osType
nicerloop May 13, 2026
82cf18e
use os.rename instead of os.execute
nicerloop May 13, 2026
6cd7c34
use os.rename and cmd.exec with cwd defined on windows
nicerloop May 14, 2026
237ac93
Revert "use os.rename and cmd.exec with cwd defined on windows"
nicerloop May 15, 2026
947b067
Revert "use os.rename instead of os.execute"
nicerloop May 15, 2026
6d0a6e7
use cmd.exec instead of os.execute to define cwd on windows
nicerloop May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions hooks/post_install.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,46 @@ function PLUGIN:PostInstall(ctx)
-- So we need to reorganize: move rootPath/* to rootPath/cmdline-tools/VERSION/

local temp_path = root_path .. "-temp"
local target_path = file.join_path(root_path, "cmdline-tools", version)
local parent_path = file.join_path(root_path, "cmdline-tools")
local target_path = file.join_path(parent_path, version)

-- Move current rootPath to temp location
os.execute("mv " .. root_path .. " " .. temp_path)
-- Cross-platform file operations (works on Unix and Windows)
local win = RUNTIME.osType == "windows"
local cmd = require("cmd")

-- Recreate rootPath with proper structure
os.execute("mkdir -p " .. target_path)
-- Move current rootPath to temp location
if win then
local systemroot = os.getenv("SystemRoot") or "C:\\Windows"
cmd.exec('move "' .. root_path .. '" "' .. temp_path .. '"', {cwd = systemroot})
else
cmd.exec('mv "' .. root_path .. '" "' .. temp_path .. '"')
end

-- Move contents from temp to target
os.execute("mv " .. temp_path .. "/* " .. target_path .. "/")
-- Recreate parent_path with proper structure
if win then
local systemroot = os.getenv("SystemRoot") or "C:\\Windows"
cmd.exec('mkdir "' .. parent_path .. '"', {cwd = systemroot})
else
cmd.exec('mkdir -p "' .. parent_path .. '"')
end

-- Clean up temp
os.execute("rm -rf " .. temp_path)
-- Move temp to target
if win then
local systemroot = os.getenv("SystemRoot") or "C:\\Windows"
cmd.exec('move "' .. temp_path .. '" "' .. target_path .. '"', {cwd = systemroot})
else
cmd.exec('mv "' .. temp_path .. '" "' .. target_path .. '"')
end

-- Verify installation
local sdkmanager_path = file.join_path(target_path, "bin", "sdkmanager")
local ext = win and ".bat" or ""
local sdkmanager_path = file.join_path(target_path, "bin", "sdkmanager" .. ext)
if not file.exists(sdkmanager_path) then
error("Installation verification failed: sdkmanager not found at " .. sdkmanager_path)
end

-- Make sure binaries are executable (for Unix systems)
os.execute("chmod +x " .. file.join_path(target_path, "bin", "*") .. " 2>/dev/null || true")
if not win then
cmd.exec("chmod +x " .. file.join_path(target_path, "bin", "*") .. " 2>/dev/null || true")
end
end