Skip to content

feat: add installed optional sdk tools to path #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Jul 16, 2026
Merged

feat: add installed optional sdk tools to path #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
651175b
feat: add installed optional sdk tools to path
imaspen Dec 16, 2025
46c7d81
test: verify optional android sdk tools on path
jdx Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
mise list-all android-sdk
mise install android-sdk@13.0
mise exec android-sdk@13.0 -- sdkmanager --version
echo y | mise exec android-sdk@13.0 -- sdkmanager platform-tools
mise exec android-sdk@13.0 -- adb version

unit-test:
runs-on: ubuntu-latest
Expand Down
16 changes: 15 additions & 1 deletion hooks/env_keys.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function PLUGIN:EnvKeys(ctx)
-- Structure is: install_path/cmdline-tools/VERSION/bin
local bin_path = file.join_path(install_path, "cmdline-tools", version, "bin")

return {
local env_vars = {
{
key = "PATH",
value = bin_path,
Expand All @@ -25,4 +25,18 @@ function PLUGIN:EnvKeys(ctx)
value = install_path,
},
}

-- Add tools installed with sdkmanager to PATH, if they exist
local optional_bin_paths = { "platform-tools", "emulator" }
for _, relative_optional_bin_path in ipairs(optional_bin_paths) do
local optional_bin_path = file.join_path(install_path, relative_optional_bin_path)
if file.exists(optional_bin_path) then
table.insert(env_vars, {
key = "PATH",
value = optional_bin_path,
})
end
end

return env_vars
end
Loading