Skip to content

Fix distributed peer build failing on VCS stamping in CI #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanphx merged 1 commit into from
Jul 23, 2026
Merged

Fix distributed peer build failing on VCS stamping in CI #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hack/dev-distributed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ bootstrap_peer() {
echo " Bootstrapping $peer..."
# Run the common setup (cgroups, kernel mounts, dirs, host user, etc.)
peer_exec "$peer" bash -c "source hack/common-setup.sh && setup_cgroups && setup_environment && setup_host_user && setup_kernel_mounts"
# The build runs as root in the peer, but /src is owned by the host user,
# so git's dubious-ownership check aborts `git status` (exit 128) and Go's
# build VCS stamping fails the build. Unlike the standalone dev flow
# (hack/dev.sh), which builds as the host user, this path builds as root, so
# mark /src safe. Mirrors hack/package-release.sh.
peer_exec "$peer" git config --global --add safe.directory /src
# Build binary
peer_exec "$peer" make bin/miren
# Symlinks
Expand Down
Loading