Skip to content

Reject unsupported Rev A firmware patching#3

Closed
ericlewis wants to merge 1 commit into
codex/validate-firmware-patcher-inputsfrom
codex/disable-reva-patching
Closed

Reject unsupported Rev A firmware patching#3
ericlewis wants to merge 1 commit into
codex/validate-firmware-patcher-inputsfrom
codex/disable-reva-patching

Conversation

@ericlewis

Copy link
Copy Markdown
Collaborator

Summary

  • Stop advertising Rev A/AB as patch targets.
  • Exit early with a clear message when Rev A is selected.
  • Leave the existing Rev B path in place.

Why

Rev A still needs a real pointer patch before its loader can run. That code is not ready yet. The script used to make a file that looked patched even though Rev A would not actually start the loader.

Verification

  • python3 -m py_compile combine.py
  • printf A into combine.py and verified it exits with the Rev A unsupported error
  • git diff --check

@ericlewis ericlewis changed the title [codex] Reject unsupported Rev A firmware patching Reject unsupported Rev A firmware patching May 10, 2026
@ericlewis ericlewis added bug Something isn't working firmware Firmware hooks, patching, and version-specific code labels May 10, 2026
@ericlewis ericlewis self-assigned this May 10, 2026
@ericlewis ericlewis requested a review from scratchminer May 10, 2026 04:45
@ericlewis ericlewis marked this pull request as ready for review May 10, 2026 04:47
Why: Rev A still needs a real pointer patch before its loader can run. That code is not ready yet. The script used to make a file that looked patched even though Rev A would not actually start the loader. This stops early with a clear message instead.
@ericlewis ericlewis force-pushed the codex/disable-reva-patching branch from bd65f63 to 532a642 Compare May 10, 2026 05:09
@ericlewis ericlewis changed the base branch from main to codex/validate-firmware-patcher-inputs May 10, 2026 05:10
@ericlewis

Copy link
Copy Markdown
Collaborator Author

Replaced by #14 with the cleaned branch name.

@ericlewis ericlewis closed this May 10, 2026
@ericlewis ericlewis deleted the codex/disable-reva-patching branch May 10, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working firmware Firmware hooks, patching, and version-specific code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant