Add playback quality controls to Apple TV#119
Open
Veeit wants to merge 9 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
perVideoQuality records the user's pick for the current video (survives CDN-failure reverts of selectedFormat, cleared on reset()); effectiveQuality resolves pick-else-default for recovery paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
attemptURL's variant selection and ABR hints now read effectiveQuality so a mid-playback 403 recovery keeps the user's per-video choice instead of snapping back to the Settings default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Picking a quality in the player no longer writes AppSettings.preferredQuality; the Settings value is now a true default applied to each new video. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Opens the existing qualityPickerOverlay (already focus-wired for tvOS). Also fixes the Stats for Nerds row highlighting when Cancel was focused and removes the dead moreMenuVisibleRows property. UI test added; running it locally is currently blocked by the pre-existing Crashlytics run-script phase failure (missing gitignored GoogleService-Info.plist) — app code compiles and links for tvOS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Default tvOS button style rendered a bright white platter on the dark sheet. PickerHeaderButtonStyle shows a gray focus highlight instead, matching the more-menu rows. iOS/macOS unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Per-video picks are temporary now, so the Settings value is a true default rather than a sticky max resolution. Existing translations kept but marked needs_review since the label's meaning shifted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Veeit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-video playback quality selection on tvOS and makes the Settings quality preference behave as a true default rather than a value the player silently overwrites. Also fixes a couple of tvOS UI issues found along the way.
Previously, the quality picker overlay existed and was fully wired for the Siri Remote, but nothing on tvOS ever opened it — the iOS quick-access pill row is #if !os(tvOS) and the …-menu had no quality entry. On top of that, picking a quality (on any platform) permanently overwrote the global preferredQuality setting.
What changed