You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some projects I would be able to exclude some files and folders from ack request. After I read your documentation I think that this change is good option to allow this.
(helpfull with local vimrc plugins)
Hi, thanks for your patch. Your suggestion makes sense to me, without it I'm not really sure why g:ack_default_options even exists, since you could put options that you want always into the g:ackprg setting itself (perhaps it's to be able to leave options like --column out of :AckFile, though there is already code to deal with that to some degree). So I agree that being able to change it at runtime makes it more useful.
Would you mind rebasing your branch? The location of the let l:ackprg_run line has moved, no other change in its behavior. And you can remove the line from plugin/ack.vim instead of commenting it out, please.
Regardant use cases, the nomenclature is just misleading. I assumed that the prg option should only contain the program name 'ag' and its parameters had to go into the options option.
Regardant use cases, the nomenclature is just misleading. I assumed that the prg option should only contain the program name 'ag' and its parameters had to go into the options option.
Including more than just the executable name in g:ackprg makes sense if you consider that 'grepprg' works the same way, but I agree that it's potentially confusing for both g:ackprg and g:ack_default_options to be public configurable variables. Documentation could perhaps be more clear as @Konfekt said in #139, but docs aren't the answer if there isn't a strong reason for one of the settings to exist at all.
I'll give some thought to removing g:ack_default_options completely and just applying the options that the plugin currently uses after trying to detect whether ack or ack-grep is available. If people want to customize the arguments, they can include them in a custom g:ackprg value, which could be done in a local vimrc (or manually at runtime) as well. Personally I already do this with let g:ackprg = "ag --vimgrep" and it's all dandy.
ches
added a commit
that referenced
this pull request
Jun 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some projects I would be able to exclude some files and folders from ack request. After I read your documentation I think that this change is good option to allow this.
(helpfull with local vimrc plugins)