MILAB-6700: raise HTTP/2 connection window + bump quickjs-emscripten - #1772
Merged
Conversation
grpc-js 1.14.0 (grpc/grpc-node#2971) made grpc-node.flow_control_window drive the connection-level window via setLocalWindowSize, not just the per-stream initial window. Bumping off 1.13.4 and setting it to 16 MiB lifts the client connection window from Node's 64 KB default.
0.32.0 upgrades bellard/quickjs to 2025-09-13 and reworks newFunction binding onto HostRef. Our newFunction/setProp/consume pattern verified unchanged for return values, host error propagation and repeated context disposal.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🦋 Changeset detectedLatest commit: 497ad12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kevindetry-milaboratories
approved these changes
Aug 4, 2026
xnacly
enabled auto-merge
August 4, 2026 09:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
=======================================
Coverage 52.91% 52.91%
=======================================
Files 370 370
Lines 19994 19994
Branches 4435 4435
=======================================
+ Hits 10579 10580 +1
- Misses 8107 8110 +3
+ Partials 1308 1304 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two Desktop-App-side items from MILAB-6700, one commit each. Both come out of the MILAB-6303 slow-network spec (text#190, A-0019 / A-0020).
1. HTTP/2 connection window (grpc-js 1.14.4)
The spec called this a blocked item needing an upstream grpc-js change plus a
patch-packageshim. That upstream change has since landed, so no patch is needed:grpc-node.flow_control_windowdrives the connection-level window viasession.setLocalWindowSize(), not just the per-stream initial window. Under 1.13.4 the option was per-stream only, which is why the spec assessed it as insufficient.Changes: catalog pin
~1.13.4->~1.14.4, andgrpc-node.flow_control_window: 16 MiBon the client options inpl-client.2. quickjs-emscripten 0.32.0
quickjs (wasm) is the top remaining worker CPU cost (~18% of active CPU under load, ~66% at baseline). 0.32.0 upgrades bellard/quickjs to 2025-09-13, moves to Emscripten 5.0.1, and reworks
newFunctionhost binding onto a newHostRefabstraction.Greptile Summary
The PR increases the gRPC client’s HTTP/2 flow-control window and upgrades the QuickJS WebAssembly runtime.
grpc-node.flow_control_windowto 16 MiB forLLPlClientgRPC transports and moves@grpc/grpc-jsto 1.14.4, where the setting also initializes the connection-level window.quickjs-emscriptenfrom 0.31.0 to 0.32.0 for middle-layer rendering, MCP-server sandboxing, and integration-test consumers.LLPlClientgRPC channels.grpc-node.flow_control_window— grpc-js channel option controlling stream and connection flow-control capacity; newly configured to 16 MiB.@grpc/grpc-js— Node.js gRPC implementation used by Platforma clients; upgraded from 1.13.4 to 1.14.4 so the configured window applies at session start.quickjs-emscripten0.32.0.newFunction; introduced by the dependency upgrade without direct source changes in this PR.LLPlClient— low-level Platforma backend client that creates gRPC or REST transports; its gRPC initialization now supplies the larger flow-control window.Confidence Score: 5/5
The PR appears safe to merge, with the dependency resolutions and central gRPC transport configuration aligned with the stated changes.
The larger HTTP/2 window reaches the primary gRPC transport construction path, reconnect and proxy paths preserve the same options, supported runtime requirements remain compatible, and no concrete QuickJS ownership or packaging regression was established.
Important Files Changed
Sequence Diagram
Reviews (1): Last reviewed commit: "MILAB-6700: bump quickjs-emscripten to 0..." | Re-trigger Greptile
Context used: