Use "url_from" to validate destination_path to avoid potential open redirect attack - #271
Open
mish-tan wants to merge 4 commits into
Open
Use "url_from" to validate destination_path to avoid potential open redirect attack #271mish-tan wants to merge 4 commits into
mish-tan wants to merge 4 commits into
Conversation
Contributor
Author
|
CI is failing but it looks unrelated to my change... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
I updated the read me and added tests to confirm new behaviour.
Users who are currently relying on both destination_path and allow_other_host will need to update their code.