sqlite, test: add support for readBigInts option in db connection level#6
Closed
miguelmarcondesf wants to merge 1 commit into
Closed
sqlite, test: add support for readBigInts option in db connection level#6miguelmarcondesf wants to merge 1 commit into
miguelmarcondesf wants to merge 1 commit into
Conversation
miguelmarcondesf
force-pushed
the
readbigints-sqlite
branch
from
18de9c7 to
6836df6
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for a new readBigInts option on the database connection level, allowing the caller to choose whether big integers are returned as BigInts or as numbers.
- Adds validation for the readBigInts option in the DatabaseSync constructor
- Updates tests to verify behavior when readBigInts is given as a boolean and when it is not
- Introduces new getter/setter methods in the configuration and propagates the setting to statement objects
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/parallel/test-sqlite-database-sync.js | Added tests validating error behavior and supporting functionality for readBigInts |
| src/node_sqlite.h | Introduced new inline methods for setting/getting the use_big_ints flag in the database configuration |
| src/node_sqlite.cc | Updated DatabaseSync constructor to handle the readBigInts option and propagate its value to StatementSync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.