feat(tools): implement call-time ask egress approval flow (Phase 2 Slice 5a) - #13
Closed
SarkarShubhdeep wants to merge 2 commits into
Closed
feat(tools): implement call-time ask egress approval flow (Phase 2 Slice 5a)#13SarkarShubhdeep wants to merge 2 commits into
SarkarShubhdeep wants to merge 2 commits into
Conversation
Break external integrations into approval/OAuth foundations, Drive and YouTube workstreams, and pin Time Huddle until API availability is confirmed. Co-authored-by: Cursor <cursoragent@cursor.com>
…ice 5a) - Rename disposition keys: drive → read_drive, youtube → post_youtube/fetch_youtube - Add ToolEgress and ApprovalStore types to ToolContext - Implement wrapToolsWithAsk to wrap tool execute with approval checks - Add tool_approvals migration for pending/grant persistence - Wire approval store and resume grant flow in worker - Add unit tests for wrap-ask and approval-store modules - Document integration tools require egress: allow-tools in README Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Will create combined PR after Slice 5 is completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drive/youtubeto tool names:read_drive,post_youtube,fetch_youtubewrapToolsWithAsk) that checks tool disposition before executiontool_approvalsmigration for pending/grant persistenceTest plan
wrap-ask.ts(suspend/grant/allow cases)approval-store.ts(memory implementation)egress: "allow-tools"and ask-disposition tool suspends → user confirms → tool runsPhase 2 Slice 5a Checklist
askwrapper implementedwaiting_for_approvalsurfaced to user (via existing CLI support)Made with Cursor