terminal: track activation outcomes and confirmed state - #1823
Open
Eleanor Boyd (eleanorjboyd) wants to merge 1 commit into
Open
Eleanor Boyd (eleanorjboyd) wants to merge 1 commit into
Eleanor Boyd (eleanorjboyd) wants to merge 1 commit into
Conversation
Distinguish shell command success, failure, timeout and unknown completion before updating activation state. Record bounded telemetry for both shell integration and unverified sendText attempts, with regression coverage for deactivation and environment switching.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Eleanor Boyd (eleanorjboyd)
September 25, 2026 17:29
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Telemetry failures can mask successful commands and prevent state updates.
Review effort: Lite
Findings: None
What changed in this PR
Adds terminal activation outcome tracking, confirmed state updates, bounded telemetry, and unit coverage.
Changes:
- Tracks success, failure, timeout, unknown, and legacy unverified outcomes.
- Adds trigger and execution telemetry.
- Expands activation state and environment-switching tests.
| File | Summary |
|---|---|
src/test/features/terminal/terminalActivationState.unit.test.ts |
Tests outcome and state-transition scenarios. |
src/features/terminal/terminalManager.ts |
Supplies activation triggers. |
src/features/terminal/terminalActivationState.ts |
Tracks outcomes and confirmed activation state. |
src/common/telemetry/constants.ts |
Defines telemetry event properties and classifications. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vritant Bhardwaj (vritant24)
approved these changes
Sep 25, 2026
Eleanor Boyd (eleanorjboyd)
added a commit
that referenced
this pull request
Sep 25, 2026
## Summary - Return `off` when the legacy `python.terminal.activateEnvironment` setting is false, without writing a persistent `python-envs.terminal.autoActivationType` override from a getter. - Preserve precedence for an explicitly set Python Environments activation mode. - Cover false-to-true legacy setting changes and verify lookup never calls configuration update. The setting is machine-scoped, so the previous implicit workspace-target write likely failed rather than persisting for users; this still removes an unnecessary, unawaited write attempt. This PR is independent of #1823 and contains only the getter and related tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendText, reporting it asunverified.Closes #1822.