Fix terminal auto-activation migration to target User settings - #1807
Draft
Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 2 commits into
Draft
Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 2 commits into
Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix migration script for python-envs.terminal.autoActivationType
Fix terminal auto-activation migration to target User settings
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy activation migration omitted its configuration target, causing workspace-open sessions to attempt a prohibited Workspace settings write. The synchronous getter also dropped the update promise and retried failed writes on subsequent reads.
Migration
Precedence
python-envs.terminal.autoActivationTypeis explicitly set.falsefallback behavior while keeping the getter side-effect free.Regression coverage
python-envs.terminal.autoActivationTypemigration script incorrectly targets Workspace settings instead of User settings #1608