Skip to content

Fix terminal auto-activation migration to target User settings - #1807

Draft
Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-python-envs-auto-activation
Draft

Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-python-envs-auto-activation

Conversation

Copilot AI commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The legacy activation migration omitted its configuration target, causing workspace-open sessions to attempt a prohibited Workspace settings write. The synchronous getter also dropped the update promise and retried failed writes on subsequent reads.

  • Migration

    • Run the migration once during awaited extension activation.
    • Write through the existing User/global-scoped setter:
      await setAutoActivationType(ACT_TYPE_OFF);
    • Handle write failures without retrying from configuration reads.
  • Precedence

    • Skip migration when python-envs.terminal.autoActivationType is explicitly set.
    • Preserve the legacy false fallback behavior while keeping the getter side-effect free.
  • Regression coverage

    • Assert the write targets User settings.
    • Verify failed migrations are not retried by repeated reads.

Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix migration script for python-envs.terminal.autoActivationType Fix terminal auto-activation migration to target User settings Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python-envs.terminal.autoActivationType migration script incorrectly targets Workspace settings instead of User settings

2 participants