Skip to content

Honor selected environment when creating Python terminals - #1806

Draft
Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-create-python-terminal-button
Draft

Eleanor Boyd (eleanorjboyd) with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-create-python-terminal-button

Conversation

Copilot AI commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

“Create Python Terminal” could ignore the clicked environment, do nothing without a workspace, or activate the project environment instead.

  • Terminal creation

    • Prioritize the clicked environment.
    • Use project selection only for cwd.
    • Preserve multi-root cancellation behavior.
  • Activation

    • Carry the requested environment through shell-startup fallback instead of re-resolving it from cwd.
  • Regression coverage

    • Cover no workspace, unset/different project environments, picker cancellation, and shell fallback.
const cwd = project ? await findParentIfFile(project.uri.fsPath) : undefined;
await terminalManager.create(clickedEnvironment, { cwd });

Copilot AI and others added 2 commits September 23, 2026 20:59
Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Co-authored-by: eleanorjboyd <26030610+eleanorjboyd@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix 'Create Python Terminal' button functionality Honor selected environment when creating Python terminals Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Create Python Terminal" button doesn't work as expected

2 participants