API: create environment with name - #1802
Open
Eduardo Villalpando Mello (edvilme) wants to merge 7 commits into
Open
Eduardo Villalpando Mello (edvilme) wants to merge 7 commits into
Eduardo Villalpando Mello (edvilme) wants to merge 7 commits into
Conversation
Eduardo Villalpando Mello (edvilme)
marked this pull request as ready for review
September 22, 2026 16:42
Member
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
Rich Chiodo (rchiodo)
requested changes
Sep 22, 2026
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
I feel like the name needs to be validated to contain allowed path characters.
For example, I don't think a name of ..\..\ would work very well.
Bill Schnurr (bschnurr)
previously approved these changes
Sep 22, 2026
Bill Schnurr (bschnurr)
left a comment
Member
There was a problem hiding this comment.
Approved via Review Center.
Stella Huang (StellaHuang95)
previously approved these changes
Sep 22, 2026
Stella Huang (StellaHuang95)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Eduardo Villalpando Mello (edvilme)
dismissed stale reviews from Stella Huang (StellaHuang95) and Bill Schnurr (bschnurr)
via
September 28, 2026 19:57
ff18cf2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9796987-f9b0-451b-a3cd-35d8a950eac8
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9796987-f9b0-451b-a3cd-35d8a950eac8
Eduardo Villalpando Mello (edvilme)
enabled auto-merge (squash)
September 29, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new optional
namefield to theCreateEnvironmentOptionsfor the@vscode/python-environmentsAPI, allowing API consumers to specify a desired environment name when creating Python environments. The implementation ensures that provided names are validated and integrated into both venv and conda environment creation flows. Documentation and versioning are updated accordingly.API and Documentation Updates:
Added an optional
nameproperty toCreateEnvironmentOptions, enabling consumers to request a specific environment name during creation. The documentation (docs/README.md) and changelog (api/CHANGELOG.md) are updated to reflect this new feature. [1] [2] [3] [4]Bumped package version to
1.5.0inpackage.jsonandpackage-lock.json. [1] [2]Validation and Core Logic:
namefield to ensure it is a non-empty path segment and does not contain invalid characters (e.g.,.,..,/,This pull request introduces a new optionalnamefield to theCreateEnvironmentOptionsfor the@vscode/python-environments` API, allowing API consumers to specify a desired environment name when creating Python environments. The implementation ensures that provided names are validated and integrated into both venv and conda environment creation flows. Documentation and versioning are updated accordingly.API and Documentation Updates:
Added an optional
nameproperty toCreateEnvironmentOptions, enabling consumers to request a specific environment name during creation. The documentation (docs/README.md) and changelog (api/CHANGELOG.md) are updated to reflect this new feature. [1] [2] [3] [4]Bumped package version to
1.5.0inpackage.jsonandpackage-lock.json. [1] [2]Validation and Core Logic:
, or null bytes).
Venv Environment Creation:
name, including validation for existing directories and proper handling in both quick and step-based flows. The state management is enhanced to track if the name was supplied by the user. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Conda Environment Creation:
nameparameter, ensuring correct flow control, state management, and back-navigation logic. The implementation also ensures that the environment is created with the requested name if provided. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]