build: share API declarations across module formats - #1793
Conversation
Emit the npm package declarations once and point both ESM and CommonJS exports at the shared type tree. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb57f94f-69e9-4501-a84e-7661b191ceba
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
Scan the complete ESM and CommonJS output trees so supporting declaration files cannot be duplicated unnoticed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb57f94f-69e9-4501-a84e-7661b191ceba
|
Result: 🔴 Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: API compile validation, API package validation, Dependency and test discovery, Offline API dependency bootstrap. Summary: Verification could not complete because offline dependency setup failed: TypeScript 5.9.3 was absent from the sandbox cache. Consequently, `npm run compile` could not find `tsc`, and `npm run test:package` stopped while attempting network access before reaching its assertions. These failures are environmental rather than attributable to the PR, but no meaningful test completed successfully. Test runs: 4 failed
❌
|
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Summary
out/typesValidation
npm run compilenpm run test:package