Handle local sibling upstreams when resolving PR defaults - #8911
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix polling error for local sibling branch upstream
Handle local sibling upstreams when resolving PR defaults
Aug 27, 2026
Alex Ross (alexr00)
approved these changes
Aug 28, 2026
Alex Ross (alexr00)
marked this pull request as ready for review
August 28, 2026 10:43
Alex Ross (alexr00)
enabled auto-merge (squash)
August 28, 2026 10:43
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes PR-default resolution when a branch’s upstream is configured as a local sibling via Git’s remote = . convention, preventing the extension from misclassifying the upstream as a non-GitHub remote and repeatedly erroring during PR-default polling in stacked-branch workflows.
Changes:
- Update
FolderRepositoryManager.getOriginto treat upstream remotes with name'.'as a local-branch relationship (skip upstream-remote GitHub resolution and fall back to normal remote selection). - Add a unit test to ensure PR defaults still resolve through a GitHub remote when the branch tracks a local sibling.
Show a summary per file
| File | Description |
|---|---|
| src/github/folderRepositoryManager.ts | Skip upstream-based origin resolution when upstreamRef.remote === '.', allowing fallback GitHub remote selection. |
| src/test/github/folderRepositoryManager.test.ts | Adds regression coverage for local-sibling upstream behavior when resolving PR defaults. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Ladislau Szomoru (lszomoru)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches using Git’s
remote = .convention were misclassified as non-GitHub remotes, causing repeated PR-default polling errors in stacked-branch workflows.Origin resolution
.as a local branch relationship.Regression coverage
originwhen a branch tracks a local sibling.