Skip to content

Revert "Migrate package TypeScript settings to ESM"#2357

Closed
rzhao271 wants to merge 2 commits into
mainfrom
revert-2355-copilot/change-package-to-esm
Closed

Revert "Migrate package TypeScript settings to ESM"#2357
rzhao271 wants to merge 2 commits into
mainfrom
revert-2355-copilot/change-package-to-esm

Conversation

@rzhao271
Copy link
Copy Markdown
Collaborator

Reverts #2355 because it fails lint checks that were not caught until those checks were re-enabled.

@rzhao271 rzhao271 self-assigned this May 15, 2026
@rzhao271 rzhao271 modified the milestones: 1.122.0, 1.121.0 May 15, 2026
@rzhao271
Copy link
Copy Markdown
Collaborator Author

@copilot Re-enable lint checks in the GitHub Actions workflow

dmitrivMS
dmitrivMS previously approved these changes May 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

@copilot Re-enable lint checks in the GitHub Actions workflow

Done in 7309a5e — lint checks are re-enabled in .github/workflows/ci.yml by removing the temporary disable flag and restoring the lint step condition to run on non-minspec jobs.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
  • plugins.dprint.dev
    • Triggering command: /home/REDACTED/work/vscode-js-debug/vscode-js-debug/node_modules/dprint/dprint /home/REDACTED/work/vscode-js-debug/vscode-js-debug/node_modules/dprint/dprint fmt OPTIONS.md (dns block)
    • Triggering command: /home/REDACTED/work/vscode-js-debug/vscode-js-debug/node_modules/dprint/dprint /home/REDACTED/work/vscode-js-debug/vscode-js-debug/node_modules/dprint/dprint check (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@rzhao271
Copy link
Copy Markdown
Collaborator Author

Lint checks still fail. Closing.

@rzhao271 rzhao271 closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants