Enforcing template with a workflow - #5021
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Vidal Ortega (vidorteg)
September 15, 2026 19:21
View session
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved moderate issues affect template links and validation coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds structured GitHub issue forms and automated validation for bug reports and feature requests.
Changes:
- Replaces Markdown templates with YAML forms.
- Disables blank issue submissions.
- Adds workflow validation and closure for incomplete issues.
File summaries
| File | Summary |
|---|---|
.github/workflows/validate-issue.yml |
Validates labeled issues, but has unresolved moderate gaps for unlabeled/API submissions, required acknowledgements, and edited/reopened issues; the closure checklist also omits expected behavior (nit). |
.github/ISSUE_TEMPLATE/feature_request.yml |
Adds the structured feature form; existing callers still reference the deleted Markdown template (moderate, 2 votes). |
.github/ISSUE_TEMPLATE/feature_request.md |
Removes the legacy feature template. |
.github/ISSUE_TEMPLATE/config.yml |
Disables blank issue submissions. |
.github/ISSUE_TEMPLATE/bug_report.yml |
Adds the structured bug form; existing callers still reference the deleted Markdown template (moderate, 2 votes). |
.github/ISSUE_TEMPLATE/bug_report.md |
Removes the legacy bug template. |
Review details
Suppressed comments (3)
.github/workflows/validate-issue.yml:16
- The validator only runs when the issue already has a
bugorenhancementlabel.blank_issues_enabled: falserestricts the web form chooser, but issues created through the API (including a bug/feature-shaped title and body) can omit those labels and bypass all validation. If this workflow is intended to enforce these templates, trigger validation for those submissions independently of labels (for example, classify the form from the title/body or reject the unlabeled form-shaped issue).
if: >-
contains(github.event.issue.labels.*.name, 'bug') ||
contains(github.event.issue.labels.*.name, 'enhancement')
.github/workflows/validate-issue.yml:59
- Both issue forms mark the two
Submission checksoptions as required, butrequiredSectionscontains only the text fields, so an API-created issue with all six/two text answers filled and no checked submission acknowledgements is accepted. That leaves part of the required template unenforced; parse this section and require the expected checked options, or remove therequiredvalidations if they are not meant to be enforced here.
const values = requiredSections.map(section => {
const lines = sections.get(section);
return lines ? lines.join('\n').trim() : undefined;
});
.github/workflows/validate-issue.yml:6
- This workflow validates only the
openedevent. Because issue bodies remain editable, a reporter can remove required sections after a valid submission (or reopen an invalid issue) and leave it open without another validation run. Addeditedandreopenedto the trigger if this workflow is intended to enforce the template throughout the issue lifecycle.
issues:
types:
- opened
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ElormCoch
approved these changes
Sep 15, 2026
Vidal Ortega (vidorteg)
deleted the
user/vidorteg/fix-issue-template
branch
September 15, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforcing bug template when reporting bugs or opening feature requests