Updating dependencies - #4995
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Vidal Ortega (vidorteg)
September 10, 2026 18:00
View session
There was a problem hiding this comment.
🟡 Changes recommended
It introduces user-facing compatibility/behavior-impacting changes (minimum VS Code engine bump and DevTools fallback revision update) that need confirmation and alignment with the PR’s “no behavior change” claim.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates key runtime and dev dependencies (notably VS Code API types, TypeScript, Webpack, Puppeteer, and telemetry), and applies the necessary build/test adjustments to keep the extension building and the Jest suite running against newer ESM/module-resolution behavior.
Changes:
- Updated dependency versions and raised the extension’s minimum supported VS Code engine version.
- Adjusted build tooling (Webpack) to avoid bundling/warnings from Puppeteer-related optional/CLI modules.
- Updated telemetry imports and added Jest stubs/mocks to handle ESM-only
puppeteer-corein tests.
File summaries
| File | Description |
|---|---|
| webpack.config.js | Adds webpack fallbacks and a module replacement to avoid Puppeteer CLI/yargs bundling warnings. |
| tsconfig.json | Switches module resolution to bundler and explicitly includes node/jest ambient types for TS 6. |
| package.json | Bumps dependency versions, updates engines.vscode, and adds Jest moduleNameMapper for puppeteer-core. |
| .vscodeignore | Excludes build/ from the packaged extension. |
| build/puppeteerCliStub.js | Adds a stub module for Puppeteer’s CLI entry to prevent webpack parsing yargs. |
| test/puppeteerCoreStub.ts | Adds a Jest-only runtime stub for ESM-only puppeteer-core. |
| test/utils.test.ts | Updates telemetry module mocking to match the new export shape. |
| test/launchDebugProvider.test.ts | Updates telemetry import to a named import. |
| test/helpers/helpers.ts | Updates telemetry import and extends the fake reporter with new methods. |
| test/extension.test.ts | Updates telemetry import to a named import. |
| test/devtoolsPanel.test.ts | Updates telemetry import to a named import. |
| test/cdpTargetsProvider.test.ts | Updates telemetry import to a named import. |
| src/utils.ts | Updates the CDN fallback revision and adjusts a request-options typing detail. |
| src/screencastPanel.ts | Updates telemetry import to a named import (file reflow only otherwise). |
| src/launchDebugProvider.ts | Updates telemetry import to a named import (file reflow only otherwise). |
| src/extension.ts | Updates telemetry import to a named import; minor typing cleanups. |
| src/devtoolsPanel.ts | Updates telemetry import to a named import and removes unnecessary unknown as void casts for sync handlers. |
| src/debugTelemetryReporter.ts | Updates telemetry import and adds an error-event implementation. |
| src/cdpTargetsProvider.ts | Updates telemetry import to a named import. |
Review details
- Files reviewed: 18/20 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ElormCoch
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating dependencies to its latest version, also fixing any issues that were raised because of this updates. No behavior change in this release