fix: apply color-scheme to match VS Code theme for native scrollbar#9993
Closed
1chooo wants to merge 1 commit into
Closed
fix: apply color-scheme to match VS Code theme for native scrollbar#99931chooo wants to merge 1 commit into
1chooo wants to merge 1 commit into
Conversation
The native OS scrollbar rendered in release notes webviews was always appearing in light mode, even when VS Code is set to a dark theme. Add color-scheme CSS rules keyed to the existing body.vscode-dark, body.vscode-high-contrast, and body.vscode-light selectors so the browser engine picks the correct scrollbar style to match the active theme. Fixes microsoft/vscode#282421. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
This issue requires a change in the website infra code. |
Contributor
Author
|
Thanks for reviewing is the infra code as internal project? Or where should I create a pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color-schemeCSS rules keyed to the existingbody.vscode-dark,body.vscode-high-contrast, andbody.vscode-lightclass selectors in bothrelease-notes/css/inproduct_releasenotes.cssandremote-release-notes/css/inproduct_releasenotes.css.color-schemeto decide which OS-native scrollbar style to render, so this makes the scrollbar automatically follow the active VS Code theme with no JavaScript required.Fixes: #9176
Refs: microsoft/vscode#282421
Changes
release-notes/css/inproduct_releasenotes.css: addcolor-schemerules after thebody {}blockremote-release-notes/css/inproduct_releasenotes.css: addcolor-schemerules after thebody {}blockTest plan
Made with Cursor