self pipelines: Pass feedBaseUrl to NPM release template for internal feed publish#2336
Draft
bwateratmsft wants to merge 1 commit into
Draft
self pipelines: Pass feedBaseUrl to NPM release template for internal feed publish#2336bwateratmsft wants to merge 1 commit into
bwateratmsft wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bwateratmsft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
feedBaseUrlparameter to the NPM release pipeline config so it also publishes the released tarball to the internal Azure Artifacts feed (after the ESRP publish to npmjs.org).This passes the internal feed base URL through to the
azdo-pipelines/1es-mb-release-npm.yml@azExtTemplatestemplate.feedBaseUrlis already provided by the sharedazdo-pipelines/azcode.variables.yml@azExtTemplatestemplate that this file imports, so no other change is needed -- the diff is a single added line in.config/release.yml.Important
This PR must stay a DRAFT until the companion template change is released to
azext-pt/v1. This file consumes the template atref: azext-pt/v1, which does not yet have thefeedBaseUrlparameter (the template change is still an unmerged/unreleased PR). The release pipeline would fail to compile on the unknown parameter until the template is released.