Optimize WebSocket receive path on pre-netstandard2.1 targets#1462
Draft
Copilot wants to merge 3 commits into
Draft
Optimize WebSocket receive path on pre-netstandard2.1 targets#1462Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve websocket read async performance for netfx
Optimize WebSocket receive path on pre-netstandard2.1 targets
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves
WebSocketMessageHandler.ReadCoreAsyncfor pre-netstandard2.1TFMs by avoiding an unnecessary copy when the sequence memory can be exposed as anArraySegment<byte>. It keeps existing behavior while reducing allocations/copy work on the hot read path used by both client and server WebSocket transports.Read-path optimization (netfx / pre-2.1 branch)
contentSequenceBuilder.MemoryMarshal.TryGetArray(memory, out segment)succeeds,ReceiveAsyncnow reads directly into destination storage.Fallback correctness when direct array access is unavailable
new ArraySegment<byte>(rented, 0, memory.Length)), then copies onlyresult.Countbytes into destination memory.Buffer advancement alignment
Write(...)usage in the legacy branch withAdvance(result.Count)after receive/copy, aligning mechanics with the modern branch.