Update template - #94
Draft
Sam Harwell (sharwell) wants to merge 2 commits into
Draft
Conversation
Sam Harwell (sharwell)
force-pushed
the
update-template
branch
3 times, most recently
from
December 28, 2021 00:40
e82d8a6 to
294471d
Compare
Sam Harwell (sharwell)
marked this pull request as draft
December 28, 2021 17:52
Contributor
Author
|
Andrew Arnott (@AArnott) I'm having a bit of trouble applying the template changes. Is there something I missed? |
Member
|
Yes: The build is failing because it can't find VS 2019. Looking at that step in your yaml reveals you have a hard-coded path in there that you'll need to update for the new VS version (2022) that you're now consuming. Also, I see you still have the expand-template.yml file, which you can delete. |
Sam Harwell (sharwell)
force-pushed
the
update-template
branch
from
January 4, 2022 15:16
294471d to
b8a4438
Compare
Sam Harwell (sharwell)
pushed a commit
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to AArnott/Library.Template@c2b0252d