[libjpeg-turbo] Patch vcpkg dependencies for 3.2.0 by tartanpaint · Pull Request #52891 · microsoft/vcpkg

tartanpaint · 2026-07-14T10:46:16Z

Changes comply with the maintainer guide.
SHA512s are updated for each updated download.
The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
All patch files in the port are applied and succeed.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Exactly one version is added in each modified versions file.

The port file update will use the zlib and libspng dependencies introduced with libjpeg-turbo 3.2.0 from vcpkg rather than building additional copies of these from the libjpeg-turbo source tree.
The libjpeg-turbo patch files have been generated directly from commits in the upstream project repository and may be removed with a port update to a future version of libjpeg-turbo. Related libjpeg-turbo issue: libjpeg-turbo/libjpeg-turbo#901

Billy O'Neal (BillyONeal) · 2026-07-14T22:12:34Z

The static versions are all likely failing due to this problem GPT 5.6 Sol found:

The PR switches static turbojpeg to external libspng/zlib dependencies, but the installed libturbojpeg.pc still publishes only -lturbojpeg. Because upstream already provides pkg-config metadata, vcpkg review checks that integration when present (review guide). Static pkg-config consumers therefore miss the new dependencies introduced by the port changes (vcpkg.json, portfile.cmake); the upstream template has no Requires.private or Libs.private entry for those libraries (libturbojpeg.pc.in).

Fix: update the packaging/patch so pkg-config --static --libs libturbojpeg emits complete static link metadata for the vcpkg build. Since libspng does not currently provide a pkg-config file in vcpkg, Requires.private: spng alone is not enough unless that integration is added; otherwise use appropriate Libs.private entries for the vcpkg dependency chain and verify a static pkg-config consumer links.

You might also want to fix this other bit it found while you are here but that's not blocking:

The manifest still declares only BSD-3-Clause, while upstream documents IJG licensing for the libjpeg API and inherited code in addition to BSD-3-Clause for TurboJPEG (upstream license). vcpkg expects license metadata to match the installed package and upstream terms (manifest license docs. This mismatch predates the PR.

…-patch

…static-md since MSVC is not supported

…-patch

Kai Pastor (dg0yt) · 2026-08-06T19:01:45Z

+    find_dependency(PkgConfig)
+    if(PkgConfig_FOUND)
+      pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)
+    endif()


Using imported targets from pkgconfig is complicated for reverse dependencies with MSVC. In other ports we use the variables (and in particular <Prefix>_LINK_LIBRARIES) to get resolved libs instead.

These patches are generated from upstream libjpeg-turbo commits which will be included in the next libjpeg-turbo release. The patches may therefore be removed from the portfile when an update is available for the next version of libjpeg-turbo.
I've included comments in the portfile referencing the upstream commits used for the patch files.

That's not true in general. If we see something bogus we can fix bogus and submit the fix for bogus upstream. I agree with Kai Pastor (@dg0yt) and think this is incorrect. Zlib has conventions for how it is found in CMake, and libspng publishes CMake configs: https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/CMakeLists.txt#L65-L81

We should stay entirely in the CMake configs namespace if at all possible and it appears possible here.

Oh, I see, this is confusing because it's patches on patches. Kai Pastor (@dg0yt) I think your comment is resolved by 0002+0003 in this series.

…-patch

…nan conan-io/conan-center-index#7628

…sses

Kai Pastor (dg0yt) · 2026-08-25T05:07:00Z

+      include(FindPkgConfig)
+      pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)
+      set(SPNG_TARGET_DEFAULT PkgConfig::spng)


So this still goes against my "do not use imported targets from pkg-config" advise.
Again, the problem is that it works poorly for top-level projects in Windows because typically there is no pkg-config in the PATH. (It is resolved when building vcpkg ports, but not for top-level projects.)

Kai Pastor (dg0yt) · 2026-08-25T05:08:23Z

+    if(SPNG_LIBRARY MATCHES "PkgConfig::")
+      find_dependency(PkgConfig)
+      if(PkgConfig_FOUND)
+        pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)


REQUIRED here breaks optional find_package. This another quirk with pkg-config for transitive dependencies for imported targets.

Kai Pastor (dg0yt) · 2026-08-25T05:09:18Z

+libjpeg-turbo is compatible with built-in implementation-agnostic CMake targets:
+
+    find_package(JPEG REQUIRED)
+    target_link_libraries(main PRIVATE JPEG::JPEG)
+
+libjpeg-turbo provides CMake targets for the TurboJPEG C API:
+
+    find_package(libjpeg-turbo CONFIG REQUIRED)
+    target_link_libraries(main PRIVATE $<IF:$<TARGET_EXISTS:libjpeg-turbo::turbojpeg>,libjpeg-turbo::turbojpeg,libjpeg-turbo::turbojpeg-static>)


When this file is touched, it should re-formatted to align with heuristical output.

Suggested change

libjpeg-turbo is compatible with built-in implementation-agnostic CMake targets:

find_package(JPEG REQUIRED)

target_link_libraries(main PRIVATE JPEG::JPEG)

libjpeg-turbo provides CMake targets for the TurboJPEG C API:

find_package(libjpeg-turbo CONFIG REQUIRED)

target_link_libraries(main PRIVATE $<IF:$<TARGET_EXISTS:libjpeg-turbo::turbojpeg>,libjpeg-turbo::turbojpeg,libjpeg-turbo::turbojpeg-static>)

libjpeg-turbo is compatible with built-in implementation-agnostic CMake targets:

find_package(JPEG REQUIRED)

target_link_libraries(main PRIVATE JPEG::JPEG)

libjpeg-turbo provides CMake targets for the TurboJPEG C API:

find_package(libjpeg-turbo CONFIG REQUIRED)

target_link_libraries(main PRIVATE $<IF:$<TARGET_EXISTS:libjpeg-turbo::turbojpeg>,libjpeg-turbo::turbojpeg,libjpeg-turbo::turbojpeg-static>)

Kai Pastor (dg0yt) · 2026-08-25T05:11:35Z

+if(CMAKE_VERSION VERSION_LESS 3.12 AND CMAKE_BUILD_TYPE STREQUAL "Debug")
+    set(JPEG_LIBRARY "${JPEG_LIBRARY_DEBUG}" CACHE FILEPATH "")
+endif()


Since the wrapper is touched: CMake 3.12 is no longer supported when using vcpkg. This (and its usage further down) is obsolete.

Billy O'Neal (BillyONeal) · 2026-08-28T18:09:10Z

OK 53510 just landed so you should be able to make both CMake and pkgconfig paths work now

…-patch

tartanpaint · 2026-09-04T16:31:53Z

Billy O'Neal (@BillyONeal) Kai Pastor (@dg0yt) I've attempted to address the review comments above. Please let me know if there is more work required to make this mergable.
Regarding the system-dependency-fixes-pr-901.patch, I have included additional changes in this to try to satisfy the review comments. If these are acceptable I can then generate an upstream PR with the extra changes. Thank you.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 75ecd986-b9c4-474e-91e9-36e614aa0c3c

Victor Romero (vicroms)

Please merge tartanpaint#4 to fix usage issues.

Fix static pkg-config dependencies

tartanpaint · 2026-09-11T06:54:16Z

Please merge tartanpaint#4 to fix usage issues.

Victor Romero (@vicroms) Thank you!

tartanpaint added 3 commits July 14, 2026 11:35

[libjpeg-turbo] Patch dependencies for 3.2.0

17ebbab

Fix manifest file formatting

41fb84e

Update version database

91a63a5

tartanpaint marked this pull request as draft July 14, 2026 21:56

tartanpaint added 3 commits July 15, 2026 10:17

Updated libjpeg-turbo patch with Pkg-Config fixes

5f44fec

Fix libjpeg-turbo license in manifest

9be746e

Update version database

b666138

Marian Klymov (Nekto89) mentioned this pull request Jul 17, 2026

libjpeg-turbo: publish version 3.2.0 conan-io/conan-center-index#30568

Merged

4 tasks

tartanpaint added 15 commits July 17, 2026 17:56

Update with dependency patches from libjpeg-turbo project

1d4b86e

Update version database

816a4bf

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

f7ef5cf

…-patch

Patch libfreenect2 FindTurboJPEG.cmake to try to fix CI build

9dd768c

Expect failures for openslide for x64-windows-static and x64-windows-…

be1bb27

…static-md since MSVC is not supported

Bump port version for libfreenect2

808b8b5

Update version database

12b63c7

Fix format issue

bb02239

Fix libfreenect2 build with patch from OpenKinect/libfreenect2#1209

87954ac

Update version database

50c6f20

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

32ddf85

…-patch

Attempt to fix finding libjpeg-turbo and dependencies for libfreenect2

57b099a

Update version database

af1e9e9

Update libfreenect2 to support finding static libjpeg-turbo libs

4d62c34

Update version database

8714cb6

Kai Pastor (dg0yt) reviewed Aug 6, 2026

View reviewed changes

tartanpaint added 5 commits August 8, 2026 18:24

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

9ac1bd8

…-patch

Fix libfreenect2 cross compile resource generation with patch from Co…

924e41f

…nan conan-io/conan-center-index#7628

Update version database

b8ebb3b

Remove expected failure for libfreenect2:arm64-windows as this now pa…

c396cd1

…sses

Update libfreenect2 find_libjpegturbo.patch as per review

622c0b8

tartanpaint added 2 commits August 24, 2026 17:23

Fix typo in comment

9fa31bc

Update version database

ad0427e

Kai Pastor (dg0yt) reviewed Aug 25, 2026

View reviewed changes

Billy O'Neal (BillyONeal) removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 28, 2026

Billy O'Neal (BillyONeal) marked this pull request as draft August 28, 2026 18:09

tartanpaint added 6 commits August 31, 2026 07:32

Merge branch 'master' into libjpeg-turbo-3.2.0-dependencies-patch

b59f1c1

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

9ee6af1

…-patch

Attempt to address PkgConfig concerns

34bcf8d

Update usage file

13c9529

Remove wrapper handling for CMake versions earlier than 3.12

e53ab11

Update version database

1303536

tartanpaint added 2 commits September 4, 2026 18:59

Fixup for JPEG:JPEG target

0b88fc3

Update version database

5d915a6

tartanpaint marked this pull request as ready for review September 10, 2026 15:18

Copilot AI added 2 commits September 10, 2026 17:43

Fix static pkg-config dependencies

8fd82cd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 75ecd986-b9c4-474e-91e9-36e614aa0c3c

Correct CMake usage guidance

4a816e9

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 75ecd986-b9c4-474e-91e9-36e614aa0c3c

Victor Romero (vicroms) requested changes Sep 11, 2026

View reviewed changes

Victor Romero (vicroms) marked this pull request as draft September 11, 2026 00:48

Merge pull request #4 from vicroms/review/pr-52891-fixes

bdd628e

Fix static pkg-config dependencies

tartanpaint mentioned this pull request Sep 11, 2026

CMake config files are wrong when WITH_SYSTEM_ZLIB=ON libjpeg-turbo/libjpeg-turbo#901

Closed

tartanpaint marked this pull request as ready for review September 15, 2026 12:12

Merge branch 'master' into libjpeg-turbo-3.2.0-dependencies-patch

665f541

Victor Romero (vicroms) approved these changes Sep 18, 2026

View reviewed changes

Victor Romero (vicroms) merged commit d53f25d into microsoft:master Sep 18, 2026
16 checks passed

Conversation

tartanpaint commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Billy O'Neal (BillyONeal) commented Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Billy O'Neal (BillyONeal) commented Aug 28, 2026

Uh oh!

tartanpaint commented Sep 4, 2026

Uh oh!

Victor Romero (vicroms) left a comment

Choose a reason for hiding this comment

Uh oh!

tartanpaint commented Sep 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tartanpaint commented Jul 14, 2026 •

edited

Loading