[http-client-python] import mixin operations from init file - #7992
Merged
Conversation
iscai-msft
requested review from
Laurent Mazuel (lmazuel),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh) and
Timothee Guerin (timotheeguerin)
as code owners
July 23, 2025 18:08
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
iscai-msft
enabled auto-merge
July 23, 2025 21:42
Timothee Guerin (timotheeguerin)
approved these changes
Jul 23, 2025
Laurent Mazuel (lmazuel)
approved these changes
Jul 23, 2025
Laurent Mazuel (lmazuel)
left a comment
Laurent Mazuel (lmazuel)
left a comment
Member
There was a problem hiding this comment.
TBH, I don't understand the PR, I'm in trust mode :)
Chenjie Shi (tadelesh)
changed the title
Chenjie Shi (tadelesh)
approved these changes
Jul 24, 2025
Contributor
|
generated code meet expectation of this PR Azure/autorest.python#3135 |
Yuchao Yan (msyyc)
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we made mixin operations private, we updated all of our imports to import from the exact file it was generated in, instead of from the
operationsmodule. This makes patch changes to the mixin operation class viaoperations/_patch.pylose their effect, and was an unintended consequence. This PR fixes that, importing mixin operation classes fromoperations/__init__.pyso patch changes still take effect