-
Notifications
You must be signed in to change notification settings - Fork 385
add naming normalization for dates #11664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jorge Rangel (jorgerangel-msft)
merged 29 commits into
main
from
jorgerangel-msft-fix-unbranded-date-suffixes
Aug 20, 2026
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
42dd88a
add acaornym naming for dates
jorgerangel-msft 1582644
merge
jorgerangel-msft 9b0729d
shorten exclusion list
jorgerangel-msft 8bde832
fix: cover date time name exclusions
Copilot 875ac14
fix: preserve normalized parameter names
Copilot aa00bd3
fix: address date naming review feedback
Copilot ea24102
fix: simplify date naming normalization
Copilot b02cbaf
fix: refine date naming tests
Copilot de464c1
fix: preserve custom back compat parameter names
Copilot f177ea1
fix: generalize back compat parameter name restoration
Copilot 862f367
fix: preserve transformed back compat parameter names
Copilot 06f7bd6
fix: simplify parameter name preservation
Copilot c87e8c0
Merge remote-tracking branch 'origin/main' into jorgerangel-msft-fix-…
Copilot 8f36465
test: preserve XML date normalization assertion
Copilot 87a9e43
fix: retain request content input metadata
Copilot 0654a31
test: cover date name backcompat constructors
Copilot 1a5e99d
test: restore back compat test fixtures
Copilot 5c1aace
test: validate date suffix ctor tests with TestData
Copilot 800ac03
Merge remote-tracking branch 'origin/main' into jorgerangel-msft-fix-…
Copilot 8b0033b
Merge branch 'main' into jorgerangel-msft-fix-unbranded-date-suffixes
jorgerangel-msft 28d2373
fix: normalize date suffix for all input parameters
Copilot df07338
Merge remote-tracking branch 'origin/main' into jorgerangel-msft-fix-…
Copilot e46c8f6
test: validate convenience method signature in TestData
Copilot 3d558b1
Add back-compat regression test for date parameter forwarding in conv…
Copilot 02be6df
Validate async overloads in date parameter back-compat regression test
Copilot 357194c
Merge branch 'main' into jorgerangel-msft-fix-unbranded-date-suffixes
Copilot 05e8a3f
fix: map noun prefixes to verb forms in date name normalization
Copilot f1aaabc
fixes
jorgerangel-msft c611539
Merge branch 'main' of https://github.com/microsoft/typespec into pr/…
jorgerangel-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...ta/ClientProviderTests/BackCompatibility_DateParameterNameIsPreservedInConvenienceCall.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| public virtual global::System.ClientModel.ClientResult TestMethod(global::System.DateTimeOffset? requestDate, string ifMatch, global::System.ClientModel.Primitives.RequestOptions options) | ||
| { | ||
| using global::System.ClientModel.Primitives.PipelineMessage message = this.CreateTestMethodRequest(requestDate, ifMatch, options); | ||
| return global::System.ClientModel.ClientResult.FromResponse(Pipeline.ProcessMessage(message, options)); | ||
| } | ||
| public virtual global::System.ClientModel.ClientResult TestMethod(global::System.DateTimeOffset? requestDate = default, string ifMatch = default, global::System.Threading.CancellationToken cancellationToken = default) | ||
| { | ||
| return this.TestMethod(requestDate, ifMatch, cancellationToken.ToRequestOptions()); | ||
| } | ||
| public virtual async global::System.Threading.Tasks.Task<global::System.ClientModel.ClientResult> TestMethodAsync(global::System.DateTimeOffset? requestDate, string ifMatch, global::System.ClientModel.Primitives.RequestOptions options) | ||
| { | ||
| using global::System.ClientModel.Primitives.PipelineMessage message = this.CreateTestMethodRequest(requestDate, ifMatch, options); | ||
| return global::System.ClientModel.ClientResult.FromResponse(await Pipeline.ProcessMessageAsync(message, options).ConfigureAwait(false)); | ||
| } | ||
| public virtual async global::System.Threading.Tasks.Task<global::System.ClientModel.ClientResult> TestMethodAsync(global::System.DateTimeOffset? requestDate = default, string ifMatch = default, global::System.Threading.CancellationToken cancellationToken = default) | ||
| { | ||
| return await this.TestMethodAsync(requestDate, ifMatch, cancellationToken.ToRequestOptions()).ConfigureAwait(false); | ||
| } |
20 changes: 20 additions & 0 deletions
20
...oviderTests/BackCompatibility_DateParameterNameIsPreservedInConvenienceCall/TestClient.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using System; | ||
| using System.ClientModel; | ||
| using System.ClientModel.Primitives; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Sample | ||
| { | ||
| public partial class TestClient | ||
| { | ||
| public virtual ClientResult TestMethod(DateTimeOffset? requestDate, string ifMatch, RequestOptions options) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| public virtual Task<ClientResult> TestMethodAsync(DateTimeOffset? requestDate, string ifMatch, RequestOptions options) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...Data/ScmMethodProviderCollectionTests/ConvenienceMethodForwardsNormalizedDateParameter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| public virtual async global::System.Threading.Tasks.Task<global::System.ClientModel.ClientResult> GetThingAsync(global::System.DateTimeOffset requestOn, global::System.Threading.CancellationToken cancellationToken = default) | ||
| { | ||
| return await this.GetThingAsync(requestOn, cancellationToken.ToRequestOptions()).ConfigureAwait(false); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.