Skip to content

Fix test:api on windows #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wesley Wigham (weswigham) merged 2 commits into from
Aug 19, 2026
+4 −3
Merged

Fix test:api on windows #4917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd46543
Fix test:api on windows
weswigham Aug 19, 2026
cf033ed
Semicolon
weswigham Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Herebyfile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,8 @@ async function runTestTools() {
}

async function runTestAPI() {
await $`npm run -w @typescript/native-preview test:only`;
// await $`npm run -w @typescript/native-preview test:only`; // doesn't work on windows - some path escaping isn't done correctly, test runner runs no tests
await _$({ verbose: "short", stdio: "inherit", cwd: "./_packages/native-preview" })`node --experimental-strip-types --no-warnings --conditions @typescript/source --test ./test/**/*.test.ts`;
}

export const testTools = task({
Expand Down
2 changes: 1 addition & 1 deletion _packages/native-preview/test/async/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe("API", () => {
assert.deepEqual(commandLine.fileNames, ["/src/index.ts"]);
assert.equal(commandLine.options.strict, true);
assert.equal(
commandLine.options.outDir,
resolve(commandLine.options.outDir!),
resolve(fileURLToPath(new URL("../../../../", import.meta.url)), "dist"),
);
assert.deepEqual(commandLine.raw, {
Expand Down
2 changes: 1 addition & 1 deletion _packages/native-preview/test/sync/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe("API", () => {
assert.deepEqual(commandLine.fileNames, ["/src/index.ts"]);
assert.equal(commandLine.options.strict, true);
assert.equal(
commandLine.options.outDir,
resolve(commandLine.options.outDir!),
resolve(fileURLToPath(new URL("../../../../", import.meta.url)), "dist"),
);
assert.deepEqual(commandLine.raw, {
Expand Down