Skip to content

Use newest VSTest source filter deps#8605

Open
Evangelink wants to merge 1 commit into
mainfrom
dev/amauryleve/vstest-source-filter
Open

Use newest VSTest source filter deps#8605
Evangelink wants to merge 1 commit into
mainfrom
dev/amauryleve/vstest-source-filter

Conversation

@Evangelink
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 26, 2026 14:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the centrally-managed NuGet version for the VSTest source filter dependency used by the VSTest bridge extension.

Changes:

  • Bump Microsoft.TestPlatform.Filter.Source from 18.8.0-preview-26264-09 to 18.8.0-preview-26276-01 in central package management.
Show a summary per file
File Description
Directory.Packages.props Updates the centrally pinned version for Microsoft.TestPlatform.Filter.Source.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Copy link
Copy Markdown
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21/21 dimensions clean — no findings.


Review Summary:

This PR updates the Microsoft.TestPlatform.Filter.Source source-only package from version 18.8.0-preview-26264-09 to 18.8.0-preview-26276-01 and adds the required trailing newline per SA1518.

What the version bump brings:

  • Bug fix: Correctly handles escaped parentheses in filter expressions (e.g., Name~aaa \()
  • Feature: Supports filtering uncategorized tests via empty filter values (e.g., TestCategory=)

Evaluation:

  • Build Infrastructure: Manual version management in Directory.Packages.props is intentional for this source-only dependency (not Arcade-managed)
  • Binary Compatibility: Source-only package changes are internal implementation improvements with no breaking API changes
  • Scope: Single atomic concern (version bump + formatting fix)
  • Conventions: Trailing newline addition correctly fixes SA1518 violation; version format consistent with other preview packages

Dimensions not applicable: No code, test, or documentation changes — only dependency metadata updated.

CI checks are in progress; build validation recommended before merge.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • api.nuget.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.nuget.org"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for issue #8605 · ● 2.2M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants