Skip to content

Unify duration parsing across MTP CLI options (#8430)#8506

Merged
Evangelink merged 10 commits into
mainfrom
dev/amauryleve/unify-duration-parser
May 26, 2026
Merged

Unify duration parsing across MTP CLI options (#8430)#8506
Evangelink merged 10 commits into
mainfrom
dev/amauryleve/unify-duration-parser

Conversation

@Evangelink
Copy link
Copy Markdown
Member

@Evangelink Evangelink commented May 22, 2026

Fixes #8430.

The three duration-style CLI options used inconsistent grammars:

  • --timeout used a hand-rolled parser that only accepted single-character suffixes (h|m|s) and rejected bare numbers entirely.
  • --hangdump-timeout and --retry-failed-tests-delay used the shared TimeSpanParser, which accepts long-form suffixes (90min, 1.5hour, 5400seconds), ms/s/m/h/d, and treats bare numbers as milliseconds.

Copy-pasting a value across options would silently break (--timeout 90min errored while --hangdump-timeout 90min worked; --timeout 200 was rejected; --retry-failed-tests-delay 200 parsed as 200 ms). The existing parser also silently accepted bogus alphabetic tails (30monkey became 30 minutes because the regex's s?[a-z]* tail matched and dispatch ran StartsWith(""m"")).

What this PR does

All three options now route through a single parser:

  • TimeSpanParser regex tightened to an explicit suffix vocabulary (ms|mils?|milliseconds?|s|secs?|seconds?|m|mins?|minutes?|h|hours?|d|days?).
  • New TryParseRequireSuffix overload for callers (i.e. --timeout) that must require an explicit unit; a new TimeSpanDefaultUnit enum lets other callers express their own bare-number default unit (preserving existing ms default for --hangdump-timeout and --retry-failed-tests-delay).
  • Suffix dispatch uses OrdinalIgnoreCase (was Ordinal, breaking 1H/1M/1D).
  • Number parsing uses InvariantCulture; TimeSpan.From* calls are wrapped so overflow returns false instead of throwing.
  • --timeout validator also bounds the value to Timer.MaxSupportedTimeout (uint.MaxValue - 1 ms, ~49.7 days) so --timeout 60d produces a friendly CLI error instead of crashing inside CancellationTokenSource.CancelAfter.

Help text and error messages for all three options now describe the same grammar; XLFs regenerated for Platform, HangDump, and Retry.

Behavior changes worth calling out in release notes

  1. --timeout is now a strict superset of its previous grammar (long-form suffixes, ms, d now accepted) but rejects -1s, 1e3s, +1s, and .5s (the old float.TryParse accepted those).
  2. Bogus suffixes like 30monkey are now hard-rejected on all three options. Previously the regex silently accepted them and dispatched on the first letter.
  3. --timeout now validates against Timer.MaxSupportedTimeout.

Validation

  • TimeSpanParserTests: 89/89 pass.
  • Platform CommandLine + TimeSpan unit tests: 253/253 pass.
  • Platform acceptance HelpInfoTests + HelpInfoAllExtensionsTests + TimeoutTests (including 5 new tests for the new grammar / range guard / 30monkey rejection): 63/63 pass.
  • MSTest acceptance HelpInfoTests: 6/6 pass.

Reviews

Two rubber-duck + expert-reviewer passes. MAJOR (CancelAfter range guard), two MODERATE (API rename Required → TryParseRequireSuffix, HangDump/Retry help parity), and several NITs were addressed before pushing.

@Evangelink
Unify duration parsing across MTP CLI options (#8430)
7f8e4a0 
The three duration-style CLI options used inconsistent grammars:

* --timeout used a hand-rolled parser that only accepted single-character
  suffixes (h|m|s) and rejected bare numbers entirely.
* --hangdump-timeout and --retry-failed-tests-delay used the shared
  TimeSpanParser, which accepts long-form suffixes (90min, 1.5hour,
  5400seconds), ms/s/m/h/d, and treats bare numbers as milliseconds.

Copy-pasting a value across options would silently break: `--timeout 90min`
errored while `--hangdump-timeout 90min` worked. `--timeout 200` was
rejected; `--retry-failed-tests-delay 200` parsed as 200 ms. And the
existing parser silently accepted bogus alphabetic tails (`30monkey`
became 30 minutes because the regex's `s?[a-z]*` tail matched and dispatch
ran StartsWith("m")).

All three options now route through a single parser:

* TimeSpanParser regex tightened to an explicit suffix vocabulary
  (ms|mils?|milliseconds?|s|secs?|seconds?|m|mins?|minutes?|h|hours?|d|days?),
  so bogus tails like 30monkey are rejected.
* New TryParseRequireSuffix overload for callers (i.e. --timeout) that
  must require an explicit unit; a new TimeSpanDefaultUnit enum lets
  other callers express their own bare-number default unit.
* Suffix dispatch uses OrdinalIgnoreCase so 1H/1M/1D parse correctly.
* Number parsing uses InvariantCulture; TimeSpan.From* calls are
  wrapped so overflow returns false instead of throwing.
* --timeout validator also bounds the value to Timer.MaxSupportedTimeout
  (uint.MaxValue - 1 ms, ~49.7 days) so `--timeout 60d` produces a
  friendly CLI error instead of crashing inside
  CancellationTokenSource.CancelAfter.

Help text and error messages for all three options now describe the same
grammar; XLFs regenerated for Platform, HangDump, and Retry.

Behavior changes worth calling out:

1. --timeout is now a strict superset of its previous grammar (long-form
   suffixes, ms, d now accepted) but rejects -1s, 1e3s, +1s, and .5s
   (the old float.TryParse accepted those).
2. Bogus suffixes like 30monkey are now hard-rejected on all three
   options. Previously the regex silently accepted them and dispatched
   on the first letter.
3. --timeout now validates against Timer.MaxSupportedTimeout.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 22, 2026 15:27
Copilot AI reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Unifies duration parsing for Microsoft.Testing.Platform (MTP) CLI options by routing --timeout, --hangdump-timeout, and --retry-failed-tests-delay through a single TimeSpanParser grammar, and updates help/error text + tests to match the new behavior.

Changes:

  • Tightens and extends TimeSpanParser (explicit suffix vocabulary, case-insensitive suffix handling, invariant-culture parsing, overflow-safe TryParse, new “require suffix” API, and configurable default unit for bare numbers).
  • Updates --timeout handling to use the shared parser and adds a validation guard for Timer.MaxSupportedTimeout.
  • Refreshes help/info expectations and localized resources (Platform, HangDump, Retry) to document the unified grammar, and adds/updates unit + acceptance tests.
Show a summary per file
File Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs Adds unit tests for the expanded duration grammar, default-unit behavior, and edge cases.
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs Updates MSTest help text expectations for the new --timeout grammar.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/TimeoutTests.cs Updates timeout acceptance tests and adds new scenarios (bogus suffix tail, max-range guard, new suffix forms).
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs Updates MTP help/info expectations for --timeout to the unified grammar.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs Updates help/info expectations for --timeout, --hangdump-timeout, and --retry-failed-tests-delay with unified grammar details.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf Updates localized resource entries impacted by the new --timeout strings.
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx Updates the English help/validation strings for --timeout to the unified grammar.
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.CommonServices.cs Switches runtime consumption of --timeout to the shared TimeSpanParser API.
src/Platform/Microsoft.Testing.Platform/Helpers/TimeSpanParser.cs Implements the unified duration parsing behavior and new APIs (default units + require-suffix).
src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs Updates --timeout validation to use TimeSpanParser and applies the max supported timeout guard.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.zh-Hant.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.zh-Hans.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.tr.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.ru.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.pt-BR.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.pl.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.ko.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.ja.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.it.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.fr.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.es.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.de.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/xlf/ExtensionResources.cs.xlf Updates Retry extension localized strings for the unified duration examples/grammar.
src/Platform/Microsoft.Testing.Extensions.Retry/Resources/ExtensionResources.resx Updates Retry extension English strings to include unified examples (e.g., 500ms, 1d).
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.zh-Hant.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.zh-Hans.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.tr.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.ru.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.pt-BR.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.pl.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.ko.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.ja.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.it.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.fr.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.es.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.de.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/xlf/ExtensionResources.cs.xlf Updates HangDump extension localized help text to list unified suffix formats and bare-number default.
src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/ExtensionResources.resx Updates HangDump extension English help text to include ms/d formats and bare-number default behavior.

Copilot's findings

  • Files reviewed: 50/50 changed files
  • Comments generated: 3

Comment thread src/Platform/Microsoft.Testing.Platform/Helpers/TimeSpanParser.cs
Comment thread src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx
Comment thread test/UnitTests/Microsoft.Testing.Platform.UnitTests/Helpers/TimeSpanParserTests.cs
Evangelink
Evangelink commented May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 21/21 dimensions clean — no findings.

This PR successfully unifies duration parsing across MTP CLI options. The implementation is well-designed:

Strengths:

  • Regex tightened to explicit vocabulary, rejecting bogus suffixes
  • Overflow handled gracefully (TryCreateTimeSpan wrapper)
  • Timer.MaxSupportedTimeout validation prevents CancelAfter crashes
  • Case-insensitive suffix matching (OrdinalIgnoreCase)
  • InvariantCulture number parsing
  • Comprehensive test coverage (89/89 tests passing)
  • .xlf files properly auto-generated (not manually edited)
  • Help text consistent across all three options

Technical Review:

  • ✅ Algorithmic Correctness: Parser logic correct, edge cases handled (null, overflow, invalid input)
  • ✅ Defensive Coding: Input validation robust, range checks in place
  • ✅ Localization: .resx changes proper, .xlf auto-generated
  • ✅ API Surface: New TimeSpanDefaultUnit enum and TryParseRequireSuffix are appropriate additions (internal scope)
  • ✅ Cross-TFM: #if NET7_0_OR_GREATER correctly gates source-generated regex
  • ✅ Code Structure: Clean, readable, uses pattern matching and switch expressions appropriately
  • ✅ Naming: TryParseRequireSuffix clearly communicates intent
  • ✅ Documentation: Error messages and help text accurate and helpful

Behavior Changes (documented in PR description):

  1. --timeout now accepts long-form suffixes + ms/d (strict superset, backward compatible)
  2. Rejects previously-silently-accepted bogus inputs (-1s, 1e3s, +1s, .5s, 30monkey)
  3. Range validation against Timer.MaxSupportedTimeout (prevents runtime crash)

All changes are improvements. No issues found.

Generated by Expert Code Review (on open) for issue #8506 · ● 8.1M

@Evangelink
Address review feedback on duration parsing
3b9a8c6 
- Tighten TimeSpanParser regex so trailing whitespace is only accepted
  when a unit suffix follows (e.g. "90 " no longer matches).
- Expand PlatformCommandLineTimeoutArgumentErrorMessage to mention the
  positive value and supported range (~49.7 days), not just the suffix
  grammar. Regenerated XLFs.
- Update MSTest acceptance TimeoutTests to expect the new message.
- Update TryParse_UppercaseSuffix_ParsesCorrectly to assert the exact
  TimeSpan for each input instead of just non-zero.

Addresses review feedback on PR #8506.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Copy link
Copy Markdown
Member Author

Evangelink commented May 25, 2026

@copilot resolve the merge conflicts in this pull request

@Evangelink
Merge origin/main and resolve timeout parser conflicts
e010355 
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 25, 2026 14:32
@Evangelink Evangelink review requested due to automatic review settings May 25, 2026 14:32
Copy link
Copy Markdown
Contributor

Copilot AI commented May 25, 2026

@copilot resolve the merge conflicts in this pull request

Conflicts are resolved and merged with origin/main in commit e01035592.

Fix botched merge conflict resolution in PlatformResources
c9f2d39 
Remove duplicate <value>/<source>+<target> entries for PlatformCommandLineTimeoutArgumentErrorMessage left over from merging origin/main, which caused 'trans-unit has invalid child element source' build errors.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 25, 2026 14:56
Copilot AI reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 51/51 changed files
  • Comments generated: 4

Comment thread src/Platform/Microsoft.Testing.Platform/Helpers/TimeSpanParser.cs
Comment thread src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
Comment thread src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs Outdated
Comment thread src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs Outdated
Evangelink and others added 2 commits May 25, 2026 17:41
@Evangelink
Address review feedback: culture-invariant regex, centralize MaxSuppo…
f7ed089 
…rtedTimeout, remove dead TryParseTimeoutArgument

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Evangelink
Merge branch 'main' into dev/amauryleve/unify-duration-parser
ba86bc9
Copilot AI review requested due to automatic review settings May 25, 2026 17:05
Copilot AI reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 52/52 changed files
  • Comments generated: 1

Comment thread src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx Outdated
Evangelink and others added 2 commits May 25, 2026 22:26
@Evangelink
Merge branch 'main' into dev/amauryleve/unify-duration-parser
9ef7952
@Evangelink
Document --timeout suffix aliases (mil/sec/min) in help text
26e7b26 
Address PR #8506 review: the TimeSpanParser regex accepts mil/mils/sec/secs/min/mins
short-form aliases but they were not documented in the --timeout help text or error
message, leading users to think only 'ms'/'s'/'m'/'h'/'d' were valid. Align the
--timeout description and error message with the existing HangDump style by listing
all accepted suffixes exhaustively.

- Update PlatformCommandLineTimeoutOptionDescription and
  PlatformCommandLineTimeoutArgumentErrorMessage to list every accepted suffix.
- Update TimeSpanParser.SuffixGrammar (used by other consumers via GetGrammarHint)
  to keep the wording consistent.
- Update HelpInfo* acceptance test expectations to match.
- Add TimeoutWithValidArg_WithAliasSuffix integration test pinning that '500mil'
  flows through the --timeout option (not just the shared parser).
- Fix a pre-existing test/resx mismatch for --retry-failed-tests-delay in
  HelpInfoAllExtensionsTests that was introduced earlier in this PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 25, 2026 21:15
Copilot AI reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Extensions.HangDump/Resources/ExtensionResources.resx:192

  • HangDumpTimeoutOptionInvalidArgument is returned when --hangdump-timeout fails TimeSpanParser.TryParse(...), but the message currently says the option "expects a single timeout argument". Arity is already ExactlyOne, so this error is misleading for format/unit failures (e.g. --hangdump-timeout 30monkey). Consider changing the resource text to say it requires a valid time value and (optionally) include a few accepted examples / mention the bare-number default to milliseconds to match the updated description.
    Default is 30m.</value>
  </data>
  <data name="HangDumpTimeoutOptionInvalidArgument" xml:space="preserve">
    <value>'--hangdump-timeout' expects a single timeout argument</value>
  </data>
  • Files reviewed: 52/52 changed files
  • Comments generated: 0 new

@Evangelink
Copy link
Copy Markdown
Member Author

Evangelink commented May 26, 2026

@copilot resolve the merge conflicts in this pull request

Merge remote-tracking branch 'origin/main' into dev/amauryleve/unify-…
b781ecb 
…duration-parser

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

@copilot resolve the merge conflicts in this pull request

Merged origin/main into the branch — no conflicts to resolve, auto-merged cleanly in commit b781ecb.

@Evangelink
Fix botched merge in pt-BR / zh-Hant XLF files
6dbc33f 
The merge between this branch (which updated PlatformCommandLineTimeoutArgumentErrorMessage to a new longer English source) and origin/main (which had a OneLocBuild update translating the previous shorter source for pt-BR and zh-Hant) was resolved by stacking both <source>/<target> pairs inside a single <trans-unit>. This left those two files structurally invalid (duplicate <source> and <target> children, effectively a missing </trans-unit>) and inconsistent with all other languages.

Remove the stale OneLocBuild <source>/<target> pair (which was for the old English source) so each <trans-unit> has a single <source>+<target> matching the structure of the other localized files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 26, 2026 08:30
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 52/52 changed files
  • Comments generated: 0 new

@Evangelink Evangelink merged commit b107531 into main May 26, 2026
26 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/unify-duration-parser branch May 26, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MTP CLI Analysis] Duration-style options use inconsistent grammars and units

4 participants

@Evangelink