Skip to content

Add Mica Alt support to Windows Terminal (#17650)#20160

Open
Dashsouradeep wants to merge 8 commits intomicrosoft:mainfrom
Dashsouradeep:fix/mica-alt-support
Open

Add Mica Alt support to Windows Terminal (#17650)#20160
Dashsouradeep wants to merge 8 commits intomicrosoft:mainfrom
Dashsouradeep:fix/mica-alt-support

Conversation

@Dashsouradeep
Copy link
Copy Markdown

Summary

This PR adds support for the Mica Alt theme in Windows Terminal as requested in #17650.

Changes

  • The useMica setting now accepts both boolean (true/false) and string enums ("mica", "micaAlt", "none"), following the pattern of bellStyle
  • C++ logic and settings parsing are updated to allow both existing and new values
  • Associated schema, interface, and test changes are included for compatibility
  • Fixed spelling dictionary to include micaAlt/MicaAlt

Testing

  • Tested backward compatibility with boolean true/false
  • Mica effect confirmed working locally

Fixes #17650

- Expand useMica setting from boolean to MicaKind enum (none/mica/micaAlt)
- Add backward compatibility for boolean true/false values
- Update Theme.idl, MTSMSettings.h, and serialization helpers
- Update IslandWindow and NonClientIslandWindow to handle MicaKind
- Add ParseMicaKindEnumValues unit tests
- Fix spelling dictionary for micaAlt/MicaAlt
@Dashsouradeep
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@github-actions

This comment has been minimized.

Comment thread .vscode/launch.json Fixed
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

⚠️ Dictionary not found

Problems were encountered retrieving check dictionaries (cspell:dart/src/dart.txt cspell:fullstack/dict/fullstack.txt cspell:redis/dict/redis.txt cspell:dotnet/dict/dotnet.txt cspell:cpp/src/compiler-clang-attributes.txt cspell:python/src/common/extra.txt cspell:python/src/additional_words.txt cspell:cpp/src/stdlib-c.txt cspell:docker/src/docker-words.txt cspell:lua/dict/lua.txt cspell:typescript/dict/typescript.txt cspell:python/src/python/python-lib.txt cspell:cpp/src/stdlib-cmath.txt cspell:npm/dict/npm.txt cspell:powershell/dict/powershell.txt cspell:cpp/src/ecosystem.txt cspell:css/dict/css.txt cspell:latex/dict/latex.txt cspell:python/src/python/python.txt cspell:cpp/src/stdlib-cpp.txt cspell:cpp/src/stdlib-cerrno.txt cspell:shell/dict/shell-all-words.txt cspell:rust/dict/rust.txt cspell:svelte/dict/svelte.txt cspell:software-terms/dict/webServices.txt cspell:monkeyc/src/monkeyc_keywords.txt cspell:swift/src/swift.txt cspell:scala/dict/scala.txt cspell:java/src/java-terms.txt cspell:sql/src/sql.txt cspell:cpp/src/lang-jargon.txt cspell:public-licenses/src/additional-licenses.txt cspell:java/src/java.txt cspell:cpp/src/compiler-gcc.txt cspell:sql/src/tsql.txt cspell:node/dict/node.txt cspell:clojure/src/clojure.txt cspell:cpp/src/template-strings.txt cspell:gaming-terms/dict/gaming-terms.txt cspell:haskell/dict/haskell.txt cspell:ruby/dict/ruby.txt cspell:html/dict/html.txt cspell:php/dict/php.txt cspell:k8s/dict/k8s.txt cspell:public-licenses/src/generated/public-licenses.txt cspell:cpp/src/people.txt cspell:r/src/r.txt cspell:elixir/dict/elixir.txt cspell:software-terms/dict/softwareTerms.txt cspell:golang/dict/go.txt cspell:django/dict/django.txt cspell:cpp/src/lang-keywords.txt cspell:cpp/src/compiler-msvc.txt cspell:ada/dict/ada.txt).

⚠️ For more information, see check-dictionary-not-found.

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

❌ Errors and Warnings Count
⚠️ check-dictionary-not-found 54
❌ forbidden-pattern 2
⚠️ ignored-expect-variant 1

See ❌ Event descriptions for more information.

These words are not needed and should be removed Alt mica

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (2013) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt

Dictionary Entries Covers Uniquely
cspell:csharp/csharp.txt 32 2 2
cspell:aws/aws.txt 232 2 2
cspell:fonts/fonts.txt 536 1 1

Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):

    "cspell:csharp/csharp.txt",
    "cspell:aws/aws.txt",
    "cspell:fonts/fonts.txt",

To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):

"check_extra_dictionaries": []
✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Copy Markdown
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pull request seems to have many unintentional changes. please fix them.

do you have any screenshots of this Mica Alt working?

Comment thread .vscode/launch.json
"version": "0.2.0",
"configurations": [
{
"name": "Debug OpenConsole by Launching (x64, debug)",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, why'd you delete this?

Copy link
Copy Markdown
Author

@Dashsouradeep Dashsouradeep Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode/launch.json — I never meant to change this, it got included accidentally
TerminalSelection.cpp — never touched this file intentionally, somehow it got modified
Line endings in Theme.idl and ThemeTests.cpp — when I converted CRLF→LF I changed every single line, making the diff huge and messy...
Will be fixing these things ASAP..
( Please do not mind..I am new to OpenSource..but I am trying my best )

and lcurrently I am building the soln..to have a screenshot of micaAlt working...

@@ -39,7 +39,7 @@ DEFINE_ENUM_FLAG_OPERATORS(Terminal::SelectionEndpoint);
* |___w|ord
* |-end & pivot
*
* The pivot never moves until a new selection is created. It ensures that that cell will always be selected.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is correct English


}
}
// Copyright (c) Microsoft Corporation.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot accept this file with changed line endings.

}
}
}
// Copyright (c) Microsoft Corporation.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line endings are still broken

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mica Alt

3 participants