Add Mica Alt support to Windows Terminal (#17650)#20160
Add Mica Alt support to Windows Terminal (#17650)#20160Dashsouradeep wants to merge 8 commits intomicrosoft:mainfrom
Conversation
- Expand useMica setting from boolean to MicaKind enum (none/mica/micaAlt) - Add backward compatibility for boolean true/false values - Update Theme.idl, MTSMSettings.h, and serialization helpers - Update IslandWindow and NonClientIslandWindow to handle MicaKind - Add ParseMicaKindEnumValues unit tests - Fix spelling dictionary for micaAlt/MicaAlt
|
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report
|
| ❌ Errors and Warnings | Count |
|---|---|
| 54 | |
| ❌ forbidden-pattern | 2 |
| 1 |
See ❌ Event descriptions for more information.
These words are not needed and should be removed
Alt micaAvailable 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary
This includes both expected items (2013) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt
| Dictionary | Entries | Covers | Uniquely |
|---|---|---|---|
| cspell:csharp/csharp.txt | 32 | 2 | 2 |
| cspell:aws/aws.txt | 232 | 2 | 2 |
| cspell:fonts/fonts.txt | 536 | 1 | 1 |
Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):
"cspell:csharp/csharp.txt",
"cspell:aws/aws.txt",
"cspell:fonts/fonts.txt",
To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):
"check_extra_dictionaries": []✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
- ... misspelled, then please correct them instead of using the command.
- ... names, please add them to
.github/actions/spelling/allow/names.txt. - ... APIs, you can add them to a file in
.github/actions/spelling/allow/. - ... just things you're using, please add them to an appropriate file in
.github/actions/spelling/expect/. - ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in
.github/actions/spelling/patterns/.
See the README.md in each directory for more information.
🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
DHowett
left a comment
There was a problem hiding this comment.
this pull request seems to have many unintentional changes. please fix them.
do you have any screenshots of this Mica Alt working?
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Debug OpenConsole by Launching (x64, debug)", |
There was a problem hiding this comment.
.vscode/launch.json — I never meant to change this, it got included accidentally
TerminalSelection.cpp — never touched this file intentionally, somehow it got modified
Line endings in Theme.idl and ThemeTests.cpp — when I converted CRLF→LF I changed every single line, making the diff huge and messy...
Will be fixing these things ASAP..
( Please do not mind..I am new to OpenSource..but I am trying my best )
and lcurrently I am building the soln..to have a screenshot of micaAlt working...
| @@ -39,7 +39,7 @@ DEFINE_ENUM_FLAG_OPERATORS(Terminal::SelectionEndpoint); | |||
| * |___w|ord | |||
| * |-end & pivot | |||
| * | |||
| * The pivot never moves until a new selection is created. It ensures that that cell will always be selected. | |||
|
|
||
| } | ||
| } | ||
| // Copyright (c) Microsoft Corporation. |
There was a problem hiding this comment.
We cannot accept this file with changed line endings.
| } | ||
| } | ||
| } | ||
| // Copyright (c) Microsoft Corporation. |
Summary
This PR adds support for the Mica Alt theme in Windows Terminal as requested in #17650.
Changes
useMicasetting now accepts both boolean (true/false) and string enums ("mica","micaAlt","none"), following the pattern ofbellStylemicaAlt/MicaAltTesting
true/falseFixes #17650