Default agentic_app_blueprint_id to app client id in get_agentic_identity#494
Open
heyitsaamir wants to merge 1 commit into
Open
Default agentic_app_blueprint_id to app client id in get_agentic_identity#494heyitsaamir wants to merge 1 commit into
heyitsaamir wants to merge 1 commit into
Conversation
…tity When agentic_app_blueprint_id is omitted in App.get_agentic_identity, it now defaults to the app's own client/app id (self.id) instead of passing None through to AgenticIdentity. Mirrors the existing tenant-resolution style. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
heyitsaamir
requested review from
corinagum and
lilyydu
and removed request for
lilyydu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.get_agentic_identity(...)previously passedagentic_app_blueprint_idstraight through, which meant it could beNoneif the caller didn't provide it. This change makes it default to the app's own client/app id (self.id) when omitted, mirroring the existingresolved_tenant_idstyle for readability.Behavior change
agentic_app_blueprint_id=Nonewhen the caller didn't pass one.agentic_app_blueprint_idfalls back toself.id(the app'sclient_id) when omitted. An explicitly provided value is still preserved.Tests
Added two unit tests in
packages/apps/tests/test_app.py:agentic_app_blueprint_idis preservedclient_idAll checks green:
ruff format,ruff check,pyright(0 errors), andpytest packages(692 passed).Note
This stacks on the Agent 365 feature branch (#464) and targets
feature_agent365_supportas its base — notmain.